search

b-inary / desktop-postflop

[Development suspended] Advanced open-source Texas Hold'em GTO solver with optimized performance
GNU Affero General Public License v3.0
215 stars 52 forks source link

Range with assymetric suits caused the error #26

Closed 1R0NYMAN closed 9 months ago

1R0NYMAN commented 1 year ago

I tried to calculate turn but the folding ranges have suit assumetry. It caused an error: fold ranges must me suit-summetric, is there a way to disable this?

b-inary commented 1 year ago

Sorry, I did not fully understand your statement. What specific inputs did you use and what kind of problems did you face?

1R0NYMAN commented 1 year ago

The error is trivially replicated by entering non suit-summetric ranges (e.g. 33, Ah2h) for bunching effect

b-inary commented 1 year ago

I get it now. Currently, the bunching effect feature only focuses on preflop fold ranges. I don't think it makes much sense to accept suit-asymmetric ranges for the bunching effect.

The situations where suit-asymmetric ranges are needed inevitably go through a multi-way flop spot, but I don't think the current multi-way postflop solvers are mature enough. In such a situation, in terms of accuracy, I think there are many things that are more important than accurately accounting for the bunching effect.

Edit: OOP Range and IP Range can be set to any suit-asymmetric range.

1R0NYMAN commented 1 year ago

Ok, I needed it for 6-max postflop bomb pot solve where 4 players folded on the flop so bunching effect is significant. Probably this case is too niche, focusing on more important features like saving the solver outputs is more essential. You can close the issue.