b-init / ImagePaste

A simple Blender addon to grab images from your clipboard and paste as a reference image in viewport or onto the image editor.
GNU General Public License v3.0
246 stars 9 forks source link

OOP implementation and improve preferences UX #14

Closed thanhph111 closed 3 years ago

thanhph111 commented 3 years ago

Proposed changes

This pull request proposes an OOP approach to the clipboard implementation, which is better for maintenance and development. These changes also aim to improve user experience on the add-on preferences. Details:

Old preferences New preferences
Screenshot from 2021-07-21 15-01-16 Screenshot from 2021-07-21 15-02-10

Further comments

thanhph111 commented 3 years ago

@williamchange I am implementing the OOP version of macOS clipboard based on your code, but don't have any knowledge to do the test. Can you help me with this?

williamchange commented 3 years ago

I just checked it out, fixed a couple of issues and opened a PR for it. But there's still some other issues.

thanhph111 commented 3 years ago

@Yeetus3141 I suppose we did a good refactoring here, most changes are under the hood but it will help us a lot in the future. We also have a new preferences menu which saves users from having to specify a saving directory if they don't care. About the feature that moves scattered pasted images into .blend file directory when users save file, I think we should save for another PR. Is there any changes you think we should add to this?

b-init commented 3 years ago

Just tried the new build. Seems to be great! Awesome work you guys. And yep the feature of moving scattered images would be good as another PR. And I'll be working on integrating the Video Editor features into the new structure, with possible additions. Unless you've been progressing on it already?

thanhph111 commented 3 years ago

Yeah, don't worry, I plan to implement right after merging this and will request your review then.