remove name & id fields in Face.msg in favor of identity field in Person.msg
remove safe_pose field in Person.msg, so safety logic will be isolated from data model
add comments about legacy fields in Person.msg, but not removing for compatibility
remove unused message FaceList.msg
is motivated by discussion in b-it-bots/mas_domestic_robotics#152
Affected packages
mdr_find_people: this is part of the refactoring, so I think it's fine to remove the safe_pose field
Additional comments
After looking through the code in mcr_people_tracking, and mcr_leg_detection, I think they both need major refactoring and documentation if we plan to use them at all. While mcr_leg_detection seems to be a copy of Willow Garage's leg_detector, mcr_people_tracking seems worth some further examination.
Since I don't plan to spend time on that at the moment, I decided to add comments about this in Person.msg and keep the legacy fields for compatibility, at least until some other people are willing to spend some time and effort looking into it.
Changes
Face.msgin favor of identity field inPerson.msgPerson.msg, so safety logic will be isolated from data modelPerson.msg, but not removing for compatibilityFaceList.msgAffected packages
mdr_find_people: this is part of the refactoring, so I think it's fine to remove thesafe_posefieldAdditional comments
After looking through the code in
mcr_people_tracking, andmcr_leg_detection, I think they both need major refactoring and documentation if we plan to use them at all. Whilemcr_leg_detectionseems to be a copy of Willow Garage'sleg_detector,mcr_people_trackingseems worth some further examination.Since I don't plan to spend time on that at the moment, I decided to add comments about this in
Person.msgand keep the legacy fields for compatibility, at least until some other people are willing to spend some time and effort looking into it.