search

b-it-bots / mas_perception_msgs

0 stars 7 forks source link

Qualitative object info #9

Closed alex-mitrevski closed 4 years ago

alex-mitrevski commented 4 years ago

Addresses https://github.com/b-it-bots/mas_perception_msgs/issues/8

Adds two messages - NamedColor and NamedShape - which define various qualitative colours and shapes respectively. Instances of both messages have been added to the Object message.

alex-mitrevski commented 4 years ago

but color maybe is better with the default one. You can define color RGB values in code or load them from a library.

I don't think so. Since the standard colour message only allows numerical representation of colours, it's not suitable for the purpose intended here, namely qualitative description. If this information is not defined in a dedicated message, it would have to be defined in the code, but I think it's cleaner to have it as a message.

minhnh commented 4 years ago

maybe then call it ColorName or NamedColor?

alex-mitrevski commented 4 years ago

maybe then call it ColorName or NamedColor?

Yeah, that's a good suggestion. I renamed it to NamedColor.

minhnh commented 4 years ago

I would also rename Shape as NamedShape, as it's serving the same purpose.

alex-mitrevski commented 4 years ago

Yeah, I renamed that one as well.