search

b-ivey / css-project

0 stars 0 forks source link

Glen Howard - CSS #11

Open glen-dale13 opened 4 years ago

glen-dale13 commented 4 years ago

https://github.com/glen-dale13/CSS-Project

b-ivey commented 4 years ago

This is very stylish! Great use of typography. Nice font choices. Photo is a bit big, but it works.

The green color for your contact info is hard to see -- consider putting a background color on that column rail and change the text to white or a color that contrasts with the column.

You are missing the max-width code to contain your text to 960 px. It's not a big deal as the content is nicely centered on the page. Maybe I just missed it somewhere?

Finally, make sure your directory is organized correctly. All photos, even if there is only 1, should be in a img folder. And don't forget that your naming conventions on your files have to follow specific rules: lowercase letters, no spaces, and keep the names simple. The first page of any website should always be titled index.html.