search

b-ivey / css-project

0 stars 0 forks source link

Gabriel Meullion CSS #13

Open gmeullion opened 4 years ago

gmeullion commented 4 years ago

https://github.com/gmeullion/resume.html

b-ivey commented 4 years ago

Check your code. The CSS file isn't linking properly.

  1. You're missing some box-model properties.
  2. You're also missing the required max-width of 960 px.
  3. The directory set up needs a little work. All images should be in a folder, even if it's one image.
  4. Make sure you label your home page index.html. Just get in the habit of doing that with the first or only page in a project.
  5. This is missing the grids code too -- also required.

Now how are you going to tackle the website? A few pointers:

  1. You need type hierarchy. That means you need big text (headlines), medium text (labels and subheds), small type (body copy) and smaller type (copyrights, contact info).

The biggest issue I have is the content organization. With grids, you could have put your photo and contact info in a column either on the right or left. The rest of your resume could have been put into separate rows.

The fonts don't really work well together -- it's best to mix and match fonts, like pairing a stylized headline with plain type for the body copy.

I would strongly suggest you do some research on what type of website design you want to incorporate in your final project. Think about adding more color, maybe even as simple as a background color.