search

b-ivey / css-project

0 stars 0 forks source link

Yoko Hwang #6

Open yokohwang opened 4 years ago

yokohwang commented 4 years ago

https://github.com/yokohwang/css-project

b-ivey commented 4 years ago

This is really great. Very clean and minimal. It's clear you put some thought into organizing your content.

A couple of issues:

  1. I don't see a max-width for the text. It was supposed to be set at 960 pixels.

  2. I appreciate you using a nav bar at the bottom, but some of the links can't really jump anywhere. I'd have rather seen links to exertnal websites, such as the companies you've worked for that's listed in your CV.

If you're going to have a table in a grid, consider making that table the same width as the content. Or put it the left column so it fits in the smaller space better.

great job!