search

b-ivey / css-project

0 stars 0 forks source link

Anthony Kean Resume with CSS #9

Open anthonykean opened 4 years ago

anthonykean commented 4 years ago

https://github.com/anthonykean/resume2.html.git

b-ivey commented 4 years ago

Way to utilize grids! Now comes the hard part and rearranging your site to look more like an actual website. My issue is more with the design and how the content is arranged, but that's another critique I'll handle in class.

  1. You're missing the max width requirement (960 px).

  2. I wish you had a more pronounced box in this design, and not relied so much on grids. For example, consider combining your photo with the contact info. But the contact info is in a darker box with white text. Just an idea.

  3. Why do you have 4 different fonts? You had a 2-font limit. All body copy should be one font. All headlines and labels another.

  4. Finally, you were supposed to utilize a clear directory, meaning your photos should be in their own folder. Also be careful with your naming conventions on the files. Just keep it simple and use one word: index.html, work.html, and style.css. The file names would match the buttons on your navigation bar, and those nav buttons would usually be one word anyway.