b-jesch / skin.estuary.modv2

A Skin for Matrix/Nexus/Omega
Other
99 stars 32 forks source link

HDR type icon on start of video for showing what type of video is playing #142

Open frodo19 opened 9 months ago

frodo19 commented 9 months ago

Hi Jesch, its not an issue, just request. Please check that, if as a development possible is. When the movie begin to playing, would be shown in the fullscreen of the left corner, the hdr videotype icon, in 6-8 sec the auto fade/dissapear. When the movie sdr, will be nothing shown.

fanart10 fanart101 fanart102

thanks

C4Wiz commented 9 months ago

That is the job of your display to show the icon of the current video, mine is a LG C3 and displays in the upper right at the start of the video

frodo19 commented 9 months ago

That is the job of your display to show the icon of the current video, mine is a LG C3 and displays in the upper right at the start of the video

Some display made, some not. Kodi can handle theese formats now, so when user choice, to show, why not? Its an truly improvements of the skin.

C4Wiz commented 9 months ago

That is the job of your display to show the icon of the current video, mine is a LG C3 and displays in the upper right at the start of the video

Some display made, some not. Kodi can handle theese formats now, so when user choice, to show, why not? Its an truly improvements of the skin.

If the display supports the formats it will have a icon. They ALL do!!!

frodo19 commented 9 months ago

That is the job of your display to show the icon of the current video, mine is a LG C3 and displays in the upper right at the start of the video

Some display made, some not. Kodi can handle theese formats now, so when user choice, to show, why not? Its an truly improvements of the skin.

If the display supports the formats it will have a icon. They ALL do!!!

THE FIRST as I wrote, not all display made that.

Second, when the kodi switch the resolution , the black screen sometimes overwrite the display time of the badge.

Third, the request I made for Jesch, not for you.

Thanks for understanding.

b-jesch commented 9 months ago

Keep cool ;)

I agree with @C4Wiz, the display of the video type flag says nothing about the capability of displaying video types of the hardware chain of your setup. The flags just tell only about the video type inside the file but nothing about the display capability of the components (Kodi hardware, receiver, tv) within the signal chain. So it's confusing to see a "Dolby Vision" flag on the tv when a tv or receiver is only capable to process HDR/HLG or just SDR files, as this implies that the hardware is capable playing DV correctly.

Some devices (like my Hisense TV) doesn't display the video type at startup of a movie, but it's showing the signal properties within the info screen. This is the only (and correct) indication of a properly working signal chain.

frodo19 commented 9 months ago

Keep cool ;)

I agree with @C4Wiz, the display of the video type flag says nothing about the capability of displaying video types of the hardware chain of your setup. The flags just tell only about the video type inside the file but nothing about the display capability of the components (Kodi hardware, receiver, tv) within the signal chain. So it's confusing to see a "Dolby Vision" flag on the tv when a tv or receiver is only capable to process HDR/HLG or just SDR files, as this implies that the hardware is capable playing DV correctly.

Some devices (like my Hisense TV) doesn't display the video type at startup of a movie, but it's showing the signal properties within the info screen. This is the only (and correct) indication of a properly working signal chain.

Allright, when not doable I can see.

Mostly use Coreelec whitch not just show the display capability , then indicate the correct output too in playerprocessinfo Player.Process(amlogic.eoft_gamut) DV , HDR or HDR10+ When any hw of the chain not capable, these info will not shown. I thinked these infos can use, for display, but its ok. thx

b-jesch commented 9 months ago

In my opinion Player.Process(amlogic.eoft_gamut) is only available on Amlogic devices. This needs a special handling. Will take some investigation and further testing...

frodo19 commented 9 months ago

Yes, thanks for the work, and time on this. I have some Coreelec dolby vision capable box. The hdr/dv type movies output result, and the eotf can see in the picture.

Mabe can use for display these as icon, some similar path ... :

but for HDR10+ no idea..

ce_play

b-jesch commented 9 months ago

The pictures above showing the modes from CoreElec (System Process Info) or from your TV? My Box (Tanix TX3) shows always HDR10 regardless if playing HDR, HDR+ or DV even if capable to display all three formats. Displaying a HDR mode from Android based on EOTF/Gamut is useless in this case.

frodo19 commented 9 months ago

The pictures above showing the modes from CoreElec (System Process Info) or from your TV? My Box (Tanix TX3) shows always HDR10 regardless if playing HDR, HDR+ or DV even if capable to display all three formats. Displaying a HDR mode from Android based on EOTF/Gamut is useless in this case.

Yes. its from my Homatics box r 4K plus, run corelelec CE21 ne nightly. My box, and the tv can handle all this format. Maybe the tanix can just hdr10 format.

frodo19 commented 9 months ago

Btw. I tryed to use your modifications from github, and all icon working and display correctly, just the hdr10+ show symple hdr10 icon. Maybe the kodi cannot read that + ? Coreelec shows in eotf HDR10+ thanks

b-jesch commented 9 months ago

https://forum.kodi.tv/showthread.php?tid=375547

frodo19 commented 9 months ago

https://forum.kodi.tv/showthread.php?tid=375547

Thanks, yes, I tryed the String.EndsWith(Player.Process(amlogic.eoft_gamut),HDR10+) but thats not working too. Anyway here is the eotf handling in coreelec. https://github.com/CoreELEC/CoreELEC/blob/a92f6ea60b2f927f917c4053b677d05d82cb7f2e/projects/Amlogic-ce/devices/Amlogic-ng-dv/patches/linux/0016-hdmitx-add-dolby-vision-support-for-display-current-.patch#L19

b-jesch commented 9 months ago

Could you try this in Variables.xml?

<value condition="String.Contains(Player.Process(amlogic.eoft_gamut),+)">flags/fullscreen/hdrplus_fs.png</value>
frodo19 commented 9 months ago

Could you try this in Variables.xml?

<value condition="String.Contains(Player.Process(amlogic.eoft_gamut),+)">flags/fullscreen/hdrplus_fs.png</value>

Yep, I tryed, no improvements. Display just the hdr logo. I tryed remove the hdr10 related line , then no logo.

b-jesch commented 9 months ago

https://github.com/xbmc/xbmc/issues/24337

frodo19 commented 9 months ago

Its kodi bug seems. I hope they can do anything with that. But thanks for your modifications, I have not lot hdr10plus files. All other works fine in CoreElec now.

Sunset-1982 commented 9 months ago

Could you add an option to select a delay or the duration of how long the the Icon is shown? for example 3,5,7 or 10 Seconds at the start of the video. Becaus my tv needs a few seconds for the hdmi handshake and when its done, the dolby vision picture has already disapeard.

frodo19 commented 9 months ago

Could you add an option to select a delay or the duration of how long the the Icon is shown? for example 3,5,7 or 10 Seconds at the start of the video. Becaus my tv needs a few seconds for the hdmi handshake and when its done, the dolby vision picture has already disapeard.

It 7 sec now, not enough? 3, and 5 will not usable.. But maybe 7,9,11..

Sunset-1982 commented 9 months ago

really? I can see it for 1 second max, sometimes I don't see it at all. The hsmi handshake takes a while. A useroption to set it between 5 and 15 seconds would be nice, or some steps like 7,, 10 and 12

b-jesch commented 9 months ago

I've implemented 5, 7, 10, 15 secs now.

Sunset-1982 commented 9 months ago

Wow! Very nice! Thank you for the fast response!

frodo19 commented 4 months ago

Hi jesch, I really like this feature in Coreelec. But the latest CE nightly broke for me. Until 19 may worked fine. The HDR sometime shown, the DV not shown anymore. The HDR icon when playing, and then stop, and playing again sometime dont show again until the skin reboot. The DV icon not show anymore. I see the skindebug activate, sometime the Custom_1111_FullScreenResolutionInfo.xml not load at start, just the VideoFullScreen.xml.

The last changes was in Corelelec here When you have time, please see whats broken now. Thanks you

b-jesch commented 4 months ago

Loading of Custom_1111 is conditional: https://github.com/b-jesch/skin.estuary.modv2/blob/3316820ad948e55005839398c5911ecd14ca9720/xml/VideoFullScreen.xml#L6 For the moment there's nothing I can do. I suggest using the last stable version and not nightlies.