b-morgan / Skillet-Classic

World of Warcraft Classic addon
GNU General Public License v3.0
6 stars 6 forks source link

Job queue area is not displaying correctly in v1.68-wrath version. #146

Closed KnockUser closed 1 year ago

KnockUser commented 1 year ago

Version 1.68 for Wrath appears to be causing the queue window to remain empty when adding create or queue jobs to it (regardless of the type or number of operations).

These jobs are visible if Skillet is closed and reopened but I was unable to make them display without this step. I tried adding additional jobs or clearing and then adding new tasks - no success.

Restarting the game client did not fix the problem. Rolling back to v1.67 and restarting resolved this problem.

b-morgan commented 1 year ago

I cannot reproduce this issue and I have examined the code changes between 1.67 and 1.68 (and 1.69) and can find nothing that might cause this problem. Please download Skillet-Classic-1.69-wrath, verify the MD5 checksum, install, and test again.

If it still fails, please verify that it fails when Skillet-Classic is the only addon enabled. Please make a backup of your global saved variables file, Skillet-Classic.lua, and then type "/skillet flushplayerdata" or "/skillet flushalldata" (you can also delete the global saved variables file).

I will provide instructions on enabling debug output and uploading it if necessary.

KnockUser commented 1 year ago

Thanks, using v1.69 with no other addons worked here. By then going through the few other addons I use, it's a conflict with Auctionator. Having just that & Skillet enabled throws up the following error:

25x ...rfaceSkillet-Classic/Plugins/Auctionator.lua:509: attempt to index field 'API' (a nil value) [string "@Skillet-Classic/Plugins/Auctionator.lua"]:509: in function <...rfaceSkillet-Classic/Plugins/Auctionator.lua:482> [string "@Skillet-Classic/Plugins/Auctionator.lua"]:885: in function GetExtraText' [string "@Skillet-Classic/SkilletPlugin.lua"]:174: in functionGetExtraText' [string "@Skillet-Classic/UI/MainFrame.lua"]:1976: in function UpdateDetailsWindow' [string "@Skillet-Classic/UI/MainFrame.lua"]:963: in functionUpdateTradeSkillWindow' [string "@Skillet-Classic/UI/MainFrame.lua"]:2511: in function ScrollToSkillIndex' [string "@Skillet-Classic/Skillet.lua"]:1539: in functionSetSelectedSkill' [string "@Skillet-Classic/UI/MainFrame.lua"]:2432: in function `SkillButton_OnClick'

Locals: recipe =

{ vendorOnly = false numMade = 1 name = "Savory Deviate Delight" reagentData =
{ } tools =
{ } itemID = 6657 tradeID = 2550 spellID = 8238 } buyout = 0 minBuyout = nil maxBuyout = nil outputItemInfo = nil itemID = 6657 (temporary) = nil (temporary) = 1 (temporary) = nil (temporary) = nil (temporary) = nil (temporary) = "attempt to index field 'API' (a nil value)" GetMinMaxBuyout = defined @Skillet-Classic/Plugins/Auctionator.lua:457 isRetail = false addonName = "Skillet-Classic"

This error only occurs with 1.68 and 1.69 for me and is generated whenever any Skillet UI element is selected. It does not occur if Skillet is opened or closed. I hope this helps solve the mystery and thanks for the prompt response on this.

Good luck with the 10.x stuff.

b-morgan commented 1 year ago

That makes sense as there was a massive change to the Auctionator plugin in 1.68. I'm looking at the code and I believe that there might be a problem if the old Auctionator API interface is being used. What version of Auctionator are you using?

I'm using Auctionator-10.1.1 from https://www.curseforge.com/wow/addons/auctionator/files/4518765.

If you want to continue to use an older version of Auctionator, the attached zip contains a version of the plugin that should work. Auctionator.zip

KnockUser commented 1 year ago

It should be the same version (10.1.1) but I'll remove the installed copy and do a fresh install this evening. I'll report back once that's done.

update: a fresh install of Auctionator 10.1.1 works correctly here with v1.69. Thanks again for solving the problem.