b-morgan / Skillet-Classic

World of Warcraft Classic addon
GNU General Public License v3.0
6 stars 6 forks source link

Wrong Skill Data for Undermine Clam Chowder #161

Closed TrusterX closed 6 months ago

TrusterX commented 9 months ago

It looks like the Skillet Data for Undermine Clam Chowder are inconsistent. While it shows 225/250/262/275 (orange/yellow/green/grey),

i'm on 275 and it's still yellow on classic (hc):

WoWScrnShot_021224_212959-2

the same also for Tender Wolf Steak

b-morgan commented 9 months ago

This data is not something that can be obtained from the Blizzard API. There are various sources including other addons. For these two cases (and I'm sure others as well), Skillet-Classic's table does not contain entries so the source of the data is from other addons (and, obviously, they are not correct).

Skillet-Classic's own table is contained in SkillLevelData.lua which was initially populated by a user scraping the data from Wowhead. I have provided their scraper code in ScrapeWowhead.js. I do not run the scraper (I've had limited success in doing so) on a regular basis.

I'll add these two recipes to the SkillLevelData.lua file but if someone runs the scraper (hint, hint, instructions in the file) and provides an updated SkillLevelData.lua file, I'll include that in the next release. There is also a table, MissingSkillLevels, in your global saved variables file, Skillet-Classic.lua, that contains any items that you have encountered that are not contained in Skillet-Classic's table. I'll accept submissions for these as well.

https://www.wowhead.com/classic/spell=20626/undermine-clam-chowder

https://www.wowhead.com/classic/spell=22480/tender-wolf-steak

Note:

-- InitializeSkillLevels is only called if the table does not exist.
-- Force refresh with '/skillet initskilllevels'
-- or '/run Skillet:InitializeSkillLevels()'
-- or '/run Skillet.db.global.SkillLevels = nil'
b-morgan commented 9 months ago

With some help I was able to scrape Wowhead and update the skill level data for all WotLK professions.

Skillet-Classic-1.83-alpha1 contains the updated data but unfortunately, I believe the data for these two recipes is still wrong.

I'm looking at finding a different source for the data and I'll post progress here when there is some.

b-morgan commented 6 months ago

Skillet-Classic-1.86-classic (and Skillet-Classic-1.86-cata) has some experimental code included which may solve this issue. The alternate source uses tables from Wago Tools, one for "Classic Era" and one for "Classic Cataclysm". The addon CraftInfoAnywhere is needed for this code to function along with some (undocumented) chat commands to enable / disable it.

The chat command /skillet altskilllevels will toggle the use of the alternate source for "yellow/green/grey" and /skillet baseskilllevel will toggle using the alternate source for the "orange" level.

The Wago Tools table(s) do not contain the data needed to determine the transition from red to orange (i.e. the skill level minimum for learning / using a recipe) for most of the recipes. Except for the "look" of the bar graph this should have no effect on any other calculations.

I don't have characters with a high enough skill level to test your example recipe so I will need your feedback to determine if this actually solves this issue. I would like to abandon the Wowhead tables in the future so I'd also like your feedback on the changed look of the bar graph.

There are some debug statements in the code that can be enabled with /skillet debugshow and /skillet debuglevel 2. Another /skillet debugshow will turn off the chat spam.

b-morgan commented 6 months ago

Skillet-Classic-1.88-classic has removed the /skillet altskilllevels switch and uses a blend of the Wago Tools (if CraftInfoAnywhere is installed) and Wowhead data. The /skillet baseskilllevel still toggles the use of the Wago Tools "orange" level.