search

b-morgan / Skillet-Classic

World of Warcraft Classic addon
GNU General Public License v3.0
6 stars 6 forks source link

Skillups are using WotLK values for SoD #167

Closed zackeryps closed 6 months ago

zackeryps commented 6 months ago

As an example, Nightfin soup starts at 250, turns yellow at 290, green at 310, and finally grey at 330. However, the addon uses the skillup values that were changed for WotLK. E.g. Nightfin soup starts at 250, turns yellow at 275, green at 285, and finally grey at 295. This causes the calculation for %chance of a skillup to be incorrect.

b-morgan commented 6 months ago

Blizzard doesn't make these values available via the API. They are "reverse engineered" and/or "scraped" from places like Wowhead. This is a very labor intensive operation and is exasperated by having three different streams that need separate data for each.

I will take this issue under advisement but I'm not sure if a solution I can live with will be found anytime soon.

b-morgan commented 6 months ago

See #161 for additional information.

b-morgan commented 6 months ago

Skillet-Classic-1.86-classic (and Skillet-Classic-1.86-cata) has some experimental code included which may solve this issue. The alternate source uses tables from Wago Tools, one for "Classic Era" and one for "Classic Cataclysm". The addon CraftInfoAnywhere is needed for this code to function along with some (undocumented) chat commands to enable / disable it.

The chat command /skillet altskilllevels will toggle the use of the alternate source for "yellow/green/grey" and /skillet baseskilllevel will toggle using the alternate source for the "orange" level.

The Wago Tools table(s) do not contain the data needed to determine the transition from red to orange (i.e. the skill level minimum for learning / using a recipe) for most of the recipes. Except for the "look" of the bar graph this should have no effect on any other calculations.

I don't have characters with a high enough skill level to test your example recipe so I will need your feedback to determine if this actually solves this issue. I would like to abandon the Wowhead tables in the future so I'd also like your feedback on the changed look of the bar graph.

There are some debug statements in the code that can be enabled with /skillet debugshow and /skillet debuglevel 2. Another /skillet debugshow will turn off the chat spam.

b-morgan commented 6 months ago

Skillet-Classic-1.88-classic has removed the /skillet altskilllevels switch and uses a blend of the Wago Tools (if CraftInfoAnywhere is installed) and Wowhead data. The /skillet baseskilllevel still toggles the use of the Wago Tools "orange" level.

zackeryps commented 6 months ago

After updating, I noticed that it was still using the wotlk values when not using Craft Info Anywhere. Trying /skillet baseskilllevel didn't appear to alter the shown values. However, the integration with CIA appears to function based on the recipes that I checked.

Thank you. I love this addon.

b-morgan commented 6 months ago

@zackeryps, The Wowhead data has not been (and probably will not be) updated. CraftInfoAnywhere is required to use the Wago Tools data which has separate values for Classic Era and Cataclysm. The baseskilllevel switch only effects where the "orange" value starts.

I may incorporate the CraftInfoAnywhere data in a later version of Skillet-Classic.