b-morgan / Skillet-Classic

World of Warcraft Classic addon
GNU General Public License v3.0
6 stars 6 forks source link

Proff window (enchanting) will sometimes stop coming up for no apparent reason #172

Closed panlakes1 closed 6 months ago

panlakes1 commented 6 months ago

Sometimes when I open my enchanting, nothing will happen besides my bags opening. This will persist even when I exit my game or re-enable the addon or change toons. I can work around it by: opening tailoring, manually clicking the enchanting icon in skillet, and while the "click okay" skillet error message remains on screen - pressing my ench hotkey on my action bars. This will open the blizz proff window instead of skillet, but if I close the error message the blizz window will disappear as well, and obviously in this state I can't use any skillet features.   Happens on my tailoring & enchanting toon, specifically enchanting is the issue. Very random, sometimes the problem won't occur in a session at all, sometimes it'll bug out after a couple crafts and window changes, other times it'll happen immediately when I log in for the day. It most commonly happens after I've changed proff windows, mainly tailoring -> enchanting.

I've disabled all my addons until only skillet remains, problem disappears when disabling skillet but obviously not ideal since I want to use the addon lol

Sorry if it's not able to be reproduced. Let me know if you need other info that I didn't include.

b-morgan commented 6 months ago

What version of WoW?

In the classic versions of WoW before Cataclysm Classic, Enchanting is a Craft and has a separate set of API calls from all the other professions. Skillet-Classic attempts to "hide" this from the user but in your case, apparently it fails. Blizzard changed Enchanting into a TradeSkill in Cataclysm Classic.

If your issue is with Cataclysm Classic, then unless you saved queues or custom groups (most people don't), I suggest that you delete your global saved variables file, Skillet-Classic.lua and start again.

There are two ways to switch professions. The first is using action buttons, click once to open and again to close. The second is unique to Skillet-Classic and involves using the buttons in the frame. Because Enchanting is a Craft (in Classic Era) and not a TradeSkill, using the Skillet-Classic buttons require a separate dialog when switching between them.

Behind the scenes the Blizzard UI is open but hidden. For Enchanting, the Blizzard UI is required because Blizzard restricted the API call DoCraft to only work with the Blizzard UI. Skillet-Classic gets around this restriction by "stealing" the Enchant button from the Blizzard UI. Because of this "theft", the Blizzard UI needs to be "initialized" and this only happens when an action button is used to open Enchanting.

Enough background! Please try the following:

  1. When you login, open and close each of your professions with action bar buttons. This will assure that the Blizzard UI for Crafts and TradeSkills are both initialized.
  2. For a session, don't use the Skillet-Classic buttons to change professions. Does this issue appear?
  3. For a session, after the first open and close with action bar buttons, use either Skillet-Classic buttons or the action bar buttons. Does this issue appear?
b-morgan commented 6 months ago

Reopen this issue and supply the requested information.