search

b-morgan / Skillet-Classic

World of Warcraft Classic addon
GNU General Public License v3.0
6 stars 6 forks source link

Guildbook and Skillet-Classic #48

Closed b-morgan closed 3 years ago

b-morgan commented 3 years ago

From https://github.com/b-morgan/Skillet/issues/26

image

Hi so i've had this bug reported, have you noticed any issues when using guildbook?

Does skillet hide the default blizzard ui?

Regards

Sam

b-morgan commented 3 years ago

I have not noticed any issues with Skillet-Classic and Guildbook. My character's recipes appear in Guildbook.

Both Skillet and Skillet-Classic hide the default Blizzard UI.

stpain commented 3 years ago

image

I added this check to see if the characters trade/craft ui was open, this is because the addon listens to various events involving trade/craft skills and updates, as a result these events would cause Guildbook to constantly scan your tradeskill recipes when stood in or near busy areas (especially tradeskill areas).

If Skillet hides the default UI then a fix or work around will be required.

b-morgan commented 3 years ago 
if Skillet and Skillet.tradeSkillFrame and not Skillet.tradeSkillFrame:IsVisible() then

or

if SkilletFrame and not SkilletFrame:IsVisible() then

You are going to have a similar problem with Trade Skill Master when it is in its native mode.

stpain commented 3 years ago

I have written a different approach where i check if any new recipes were learnt to determine if an update is required.

b-morgan commented 3 years ago

Also Skillet-Classic and https://zygorguides.com/ have a conflict so Guildbook may as well.

stpain commented 3 years ago

Hmmm yeah.....paid for guides not something I care to go near personally.

b-morgan commented 3 years ago

Your different approach will probably cover the Zygor case as well.

b-morgan commented 3 years ago

I believe this issue has been resolved.