b-morgan / Skillet

World of Warcraft addon
GNU General Public License v3.0
14 stars 5 forks source link

error at auction house/banks #13

Closed Fagerinfoco closed 3 years ago

Fagerinfoco commented 3 years ago

Skillet Version 4.26 Locale: enUS

my wife and I are getting errors when we mouse over things in the AH or the bank. it does not happen all the time. the error is below:

Message: Usage: GameTooltip:SetHyperlink(link) Time: Sun Apr 18 09:44:34 2021 Count: 1 Stack: Usage: GameTooltip:SetHyperlink(link) [string "@Interface\AddOns\Skillet\UI\ShoppingList.lua"]:168: in function `ShoppingListButton_OnEnter'

Locals: self =

{ DeleteIgnoreEntry = defined @Interface\AddOns\Skillet\UI\IgnoreList.lua:159 RecipeGroupPruneList = defined @Interface\AddOns\Skillet\RecipeGroups.lua:506 SkillButton_NewGroup = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:2220 guildText = 0 ClearQueue = defined @Interface\AddOns\Skillet\SkilletQueue.lua:223 RecipeGroupInitFlatten = defined @Interface\AddOns\Skillet\RecipeGroups.lua:362 RecipeGroupConstructDBString = defined @Interface\AddOns\Skillet\RecipeGroups.lua:482 SkilletShow = defined @Interface\AddOns\Skillet\Skillet.lua:962 DisplayShoppingList = defined @Interface\AddOns\Skillet\UI\ShoppingList.lua:1127 ShowQueueView = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:3447 ReagentStarsFrame_OnMouseEnter = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:3598 SKILL_LINES_CHANGED = defined @Interface\AddOns\Skillet\Skillet.lua:798 SetSelectedTrade = defined @Interface\AddOns\Skillet\Skillet.lua:1332 FilterDropDown_OnShow = defined @Interface\AddOns\Skillet\UI\Filtering.lua:25 GARRISON_TRADESKILL_NPC_CLOSED = defined @Interface\AddOns\Skillet\Skillet.lua:919 hideTrivialRecipes = false SetTradeSkillLearned = defined @Interface\AddOns\Skillet\SkilletData.lua:289 guildbankQueryComplete = defined @Interface\AddOns\Skillet\UI\ShoppingList.lua:459 RecipeGroupSort = defined @Interface\AddOns\Skillet\RecipeGroups.lua:340 EnableResize = defined @Interface\AddOns\Skillet\UI\Utils.lua:72 db =
{ } bankBusy = false UpdateNotesWindow = defined @Interface\AddOns\Skillet\UI\RecipeNotes.lua:116 SetEnabledState = defined @Interface\AddOns\Skillet\Libs\AceAddon-3.0\AceAddon-3.0.lua:424 SkilletShowWindow = defined @Interface\AddOns\Skillet\Skillet.lua:1026 CHAT = defined @Interface\AddOns\Skillet\DebugAids.lua:65 HideOptionalList = defined @Interface\AddOns\Skillet\UI\OptionalList.lua:226 IgnoreList_OnScroll = defined @Interface\AddOns\Skillet\UI\IgnoreList.lua:262 SortDropdown_OnLoad = defined @Interface\AddOns\Skillet\UI\Sorting.lua:488 pluginsOptions =
{ } UnregisterAllEvents = defined @Interface\AddOns\LibSharedMedia-3.0\CallbackHandler-1.0\CallbackHandler-1.0.lua:174 RecipeGroupFlatten = defined @Interface\AddOns\Skillet\RecipeGroups.lua:378 RecipeGroupMoveEntry = defined @Interface\AddOns\Skillet\RecipeGroups.lua:237 FavoriteButton_OnClick = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:2299 SkilletShowGuildCrafters = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:3167 ITEM_DATA_LOAD_RESULT = defined @Interface\AddOns\Skillet\Skillet.lua:923 ShowReagentDetails = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:3149 bopCheck = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:1607 CHAT_MSG_SKILL = defined @Interface\AddOns\Skillet\Skillet.lua:790 SkillExpandButton_OnClick = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:2397 TABLE = defined @Interface\AddOns\Skillet\DebugAids.lua:313 FixBugs = true Unhook = defined @Interface\AddOns\Skillet\Libs\AceHook-3.0\AceHook-3.0.lua:418 InventoryFilterButton_OnShow = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:2738 SetTradeSkillToolTip = defined @Interface\AddOns\Skillet\UI\MainFrame.lua:1515 SetTradeSkill = defined @Interface\AddOns\Skillet\Skillet.lua:

b-morgan commented 3 years ago

I cannot reproduce this error with the limited context supplied. Do you and your wife play on one machine or two? Is the shopping list open? What does the shopping list contain? Is the Skillet window open at the time?

The function `ShoppingListButton_OnEnter' should only be called when the shopping list is open, not empty, and you mouseover an item in the list. How it is being called when you mouseover items in the AH or the bank doesn't make sense to me.

Fagerinfoco commented 3 years ago

we play on separate machines. the shopping list opens when we click on the AH or when we open our banks. The shopping list contains the items needed in the various crafting queues. The skillet windows itself is not open, just the shopping lists. I do need to clarify something i noticed, the error ocurs when mousing over the shopping list, however, because it opens in basically the middle of the screen, it happens almost immediately when opening the bank or AH (as the shopping list opens with it)

b-morgan commented 3 years ago

That makes a lot more sense. My guess is that it only happens on the first visit after logging in. Blizzard changed the way GetItemInfo works. Before when the WoW client didn't have the information on an item, it would wait for the server to deliver it. Now it returns immediately without supplying the requested information. Skillet-4.27-alpha should prevent the error that occurs because of this. Let me know if it works.

You can move (and resize) the shopping list (and all of the Skillet windows). I have moved mine so that it doesn't overlap with the Skillet window.

Fagerinfoco commented 3 years ago

pulled the code and it appears to be working. thank you so much for the quick fix.