search

b-morgan / Skillet

World of Warcraft addon
GNU General Public License v3.0
14 stars 5 forks source link

Wild Transmutation not removed from queue when completed #24

Closed brykrys closed 2 years ago

brykrys commented 2 years ago

Wild Transmutation (Broken Isles Alchemy) does not get removed from the queue after the cast completes. This appears to have started with Skillet version 4.34, as it was working as expected before.

This transmute has a daily cooldown, but I have 4 alts I tested it on yesterday and today to confirm. All of them have the 3-Star version.

b-morgan commented 2 years ago

The bad news... I believe this may a side effect of the changes made to fix https://github.com/b-morgan/Skillet/issues/22. The good news... I have a character that knows this recipe and the materials don't cost thousands of gold. The bad news... It may take a few days to verify the fix because of the cooldown. The good news... Skillet-4.35-alpha1 has a potential fix.

It fails for me but I'd like you to enable debugging with the following chat commands:

/skillet debuglevel 3
/skillet tabledump on
/skillet debugshow on
/skillet traceshow on

You can use a /skillet cleardebuglog just before you craft the item and then close the Skillet frame and logoff. The per character saved variables file Skillet.lua will contain all the debug output that was sent to chat. /skillet debugshow off and /skillet traceshow off will return control of chat to you.

The failure I see (which is new behavior, not related to #22) is the UNIT_SPELLCAST_FAILED_QUIET. In this case the spell is Transmute: Fish to Gems. I'm guessing you will have similar results but I'd like to see them. Either 4.34 or 4.35-alpha1 will show it in the debug log.

    "Sun Aug 22 05:34:05 2021(T): UNIT_SPELLCAST_SENT(player, nil, Cast-3-3024-1643-392-188802-006DA2362C, 188802, nil)", -- [3504]
    "Sun Aug 22 05:34:05 2021(T): UNIT_SPELLCAST_START(player, Cast-3-3024-1643-392-188802-006DA2362C, 188802, nil, nil)", -- [3505]
    "Sun Aug 22 05:34:08 2021(T): UNIT_SPELLCAST_FAILED_QUIET(player, Cast-3-3024-1643-392-213266-000BA23630, 213266, nil, nil)", -- [3506]
    "Sun Aug 22 05:34:08 2021(D0): StopCast(188802)", -- [3507]
    "Sun Aug 22 05:34:08 2021(T): UNIT_SPELLCAST_SUCCEEDED(player, Cast-3-3024-1643-392-188802-006DA2362C, 188802, nil, nil)", -- [3508]
    "Sun Aug 22 05:34:08 2021(T): UNIT_SPELLCAST_STOP(player, Cast-3-3024-1643-392-188802-006DA2362C, 188802, nil, nil)", -- [3509]
    "Sun Aug 22 05:34:08 2021(T): TRADE_SKILL_LIST_UPDATE", -- [3510]
brykrys commented 2 years ago

I used Alpha1 and the Queue did clear after completing.

I grabbed what looked like the important lines from the debug:

"Mon Aug 23 09:42:46 2021(D1): Crafting: 1 of Wild Transmutation (188802)", -- [606]
"Mon Aug 23 09:42:46 2021(D1): Optional: level= 0", -- [607]
"Mon Aug 23 09:42:46 2021(D1): Optional: recipeLevel= 0, optionalReagentsArray= { }", -- [608]
"Mon Aug 23 09:42:46 2021(T): UNIT_SPELLCAST_SENT(player, nil, Cast-3-1467-1643-21685-188802-006FA35F85, 188802, nil)", -- [609]
"Mon Aug 23 09:42:46 2021(T): UNIT_SPELLCAST_START(player, Cast-3-1467-1643-21685-188802-006FA35F85, 188802, nil, nil)", -- [610]
"Mon Aug 23 09:42:49 2021(T): UNIT_SPELLCAST_FAILED_QUIET(player, Cast-3-1467-1643-21685-224506-009E235F88, 224506, nil, nil)", -- [611]
"Mon Aug 23 09:42:49 2021(T): UNIT_SPELLCAST_SUCCEEDED(player, Cast-3-1467-1643-21685-188802-006FA35F85, 188802, nil, nil)", -- [612]
"Mon Aug 23 09:42:49 2021(D0): UNIT_SPELLCAST_SUCCEEDED: player, Cast-3-1467-1643-21685-188802-006FA35F85, 188802", -- [613]
"Mon Aug 23 09:42:49 2021(D0): ContinueCast(188802)", -- [614]
"Mon Aug 23 09:42:49 2021(D0): ContinueCast: processingCount= 1", -- [615]
"Mon Aug 23 09:42:49 2021(D0): RemoveFromQueue(1)", -- [616]
"Mon Aug 23 09:42:49 2021(D0): AdjustInventory()", -- [617]
"Mon Aug 23 09:42:49 2021(D0): ScanQueuedReagents()", -- [618]
"Mon Aug 23 09:42:49 2021(D0): CalculateCraftableCounts()", -- [619]
"Mon Aug 23 09:42:49 2021(D0): GetTradeSkillLevels(141323, 188802)", -- [620]
"Mon Aug 23 09:42:49 2021(D0): GetTradeSkillLevels: levels= 1/20/50/80", -- [621]
"Mon Aug 23 09:42:49 2021(D0): UpdateIgnoredMatsButton()", -- [622]
"Mon Aug 23 09:42:49 2021(D0): GetIgnoreList(nil)", -- [623]
"Mon Aug 23 09:42:49 2021(D0): Ignored Mats list for: all players", -- [624]
...
"Mon Aug 23 09:42:49 2021(D0): GetTradeSkillLevels(141323, 188802)", -- [635]
"Mon Aug 23 09:42:49 2021(D0): GetTradeSkillLevels: levels= 1/20/50/80", -- [636]
"Mon Aug 23 09:42:49 2021(T): UNIT_SPELLCAST_STOP(player, Cast-3-1467-1643-21685-188802-006FA35F85, 188802, nil, nil)", -- [637]
"Mon Aug 23 09:42:49 2021(T): BAG_UPDATE( 0 )", -- [638]
"Mon Aug 23 09:42:49 2021(T): BAG_UPDATE( 0 )", -- [639]
"Mon Aug 23 09:42:49 2021(T): BAG_UPDATE( 0 )", -- [640]
"Mon Aug 23 09:42:49 2021(T): BAG_UPDATE( 0 )", -- [641]
"Mon Aug 23 09:42:49 2021(T): BAG_UPDATE( 0 )", -- [642]
"Mon Aug 23 09:42:50 2021(T): TRADE_SKILL_LIST_UPDATE", -- [643]

I see there's an Alpha2, will try it on another character.

brykrys commented 2 years ago

From Alpha2:

"Mon Aug 23 10:07:30 2021(D0): CreateItems(1, LeftButton)", -- [1]
"Mon Aug 23 10:07:30 2021(D0): QueueItems(1)", -- [2]
"Mon Aug 23 10:07:30 2021(D0): QueueCommandIterate(188802, 1), name= Wild Transmutation", -- [3]
"Mon Aug 23 10:07:30 2021(D0): QueueAppendCommand({ ['recipeLevel'] = 0, ['op'] = iterate, ['count'] = 1, ['recipeName'] = Wild Transmutation, ['recipeID'] = 188802, ['tradeID'] = 2259, ['tradeName'] = Alchemy }, true, nil), visited=  nil", -- [4]
"Mon Aug 23 10:07:30 2021(D0): queueAppendReagent(124101, 5, true), name= Aethril", -- [5]
"Mon Aug 23 10:07:30 2021(D1): numInBoth= 102, numInBags=1, numInBank=101", -- [6]
"Mon Aug 23 10:07:30 2021(D1): queueCraftables= true, need= 5, have= 102", -- [7]
"Mon Aug 23 10:07:30 2021(D0): queueAppendReagent(124102, 5, true), name= Dreamleaf", -- [8]
"Mon Aug 23 10:07:30 2021(D1): numInBoth= 232, numInBags=1, numInBank=231", -- [9]
"Mon Aug 23 10:07:30 2021(D1): queueCraftables= true, need= 5, have= 232", -- [10]
"Mon Aug 23 10:07:30 2021(D0): queueAppendReagent(124103, 5, true), name= Foxflower", -- [11]
"Mon Aug 23 10:07:30 2021(D1): numInBoth= 61, numInBags=1, numInBank=60", -- [12]
"Mon Aug 23 10:07:30 2021(D1): queueCraftables= true, need= 5, have= 61", -- [13]
"Mon Aug 23 10:07:30 2021(D0): queueAppendReagent(124104, 5, true), name= Fjarnskaggl", -- [14]
"Mon Aug 23 10:07:30 2021(D1): numInBoth= 29, numInBags=5, numInBank=24", -- [15]
"Mon Aug 23 10:07:30 2021(D1): queueCraftables= true, need= 5, have= 29", -- [16]
"Mon Aug 23 10:07:30 2021(D0): queueAppendReagent(124105, 1, true), name= Starlight Rose", -- [17]
"Mon Aug 23 10:07:30 2021(D1): numInBoth= 28, numInBags=1, numInBank=27", -- [18]
"Mon Aug 23 10:07:30 2021(D1): queueCraftables= true, need= 1, have= 28", -- [19]
"Mon Aug 23 10:07:30 2021(D0): AddToQueue({ ['recipeLevel'] = 0, ['op'] = iterate, ['count'] = 1, ['recipeName'] = Wild Transmutation, ['recipeID'] = 188802, ['tradeID'] = 2259, ['tradeName'] = Alchemy }, nil)", -- [20]
"Mon Aug 23 10:07:30 2021(D0): AdjustInventory()", -- [21]
"Mon Aug 23 10:07:30 2021(D0): ScanQueuedReagents()", -- [22]
"Mon Aug 23 10:07:30 2021(D0): CalculateCraftableCounts()", -- [23]
"Mon Aug 23 10:07:30 2021(D0): GetTradeSkillLevels(141323, 188802)", -- [24]
"Mon Aug 23 10:07:30 2021(D0): GetTradeSkillLevels: levels= 1/20/50/80", -- [25]
"Mon Aug 23 10:07:30 2021(D0): UpdateIgnoredMatsButton()", -- [26]
"Mon Aug 23 10:07:30 2021(D0): GetIgnoreList(nil)", -- [27]
"Mon Aug 23 10:07:30 2021(D0): Ignored Mats list for: all players", -- [28]
...
"Mon Aug 23 10:07:30 2021(D0): GetTradeSkillLevels(141323, 188802)", -- [39]
"Mon Aug 23 10:07:30 2021(D0): GetTradeSkillLevels: levels= 1/20/50/80", -- [40]
"Mon Aug 23 10:07:30 2021(D0): GetTradeSkillLevels(141323, 188802)", -- [41]
"Mon Aug 23 10:07:30 2021(D0): GetTradeSkillLevels: levels= 1/20/50/80", -- [42]
"Mon Aug 23 10:07:30 2021(D0): ProcessQueue(false)", -- [43]
"Mon Aug 23 10:07:30 2021(D1): recipeInfo= { ['sourceType'] = 1, ['disabled'] = false, ['recipeID'] = 188802, ['numAvailable'] = 5, ['categoryID'] = 436, ['previousRecipeID'] = 188801, ['learned'] = true, ['icon'] = 134400, ['type'] = recipe, ['hiddenUnlessLearned'] = false, ['craftable'] = true, ['difficulty'] = trivial, ['productQuality'] = 1, ['name'] = Wild Transmutation, ['numIndents'] = 1, ['favorite'] = true, ['numSkillUps'] = 1 }", -- [44]
"Mon Aug 23 10:07:30 2021(D1): Crafting: 1 of Wild Transmutation (188802)", -- [45]
"Mon Aug 23 10:07:30 2021(D1): Optional: level= 0", -- [46]
"Mon Aug 23 10:07:30 2021(D1): Optional: recipeLevel= 0, optionalReagentsArray= { }", -- [47]
"Mon Aug 23 10:07:30 2021(T): UNIT_SPELLCAST_SENT(player, nil, Cast-3-3111-1220-20371-188802-0000236551, 188802, nil)", -- [48]
"Mon Aug 23 10:07:30 2021(D4): IgnoreCast(nil), nil", -- [49]
"Mon Aug 23 10:07:30 2021(T): UNIT_SPELLCAST_START(player, Cast-3-3111-1220-20371-188802-0000236551, 188802, nil, nil)", -- [50]
"Mon Aug 23 10:07:30 2021(D4): IgnoreCast(188802), Wild Transmutation", -- [51]
"Mon Aug 23 10:07:31 2021(T): UNIT_SPELLCAST_SUCCEEDED(player, Cast-13-3111-1220-20371-240022-0003A36552, 240022, nil, nil)", -- [52]
"Mon Aug 23 10:07:31 2021(D4): IgnoreCast(240022), 7.2 Broken Shore - Buildings - Activation Buff - Manager", -- [53]
"Mon Aug 23 10:07:33 2021(T): UNIT_SPELLCAST_FAILED_QUIET(player, Cast-3-3111-1220-20371-213262-0000236554, 213262, nil, nil)", -- [54]
"Mon Aug 23 10:07:33 2021(D4): IgnoreCast(213262), Transmute: Ore to Herbs", -- [55]
"Mon Aug 23 10:07:33 2021(T): UNIT_SPELLCAST_SUCCEEDED(player, Cast-3-3111-1220-20371-188802-0000236551, 188802, nil, nil)", -- [56]
"Mon Aug 23 10:07:33 2021(D0): UNIT_SPELLCAST_SUCCEEDED: player, Cast-3-3111-1220-20371-188802-0000236551, 188802", -- [57]
"Mon Aug 23 10:07:33 2021(D0): ContinueCast(188802), Wild Transmutation", -- [58]
"Mon Aug 23 10:07:33 2021(D0): ContinueCast: processingCount= 1", -- [59]
"Mon Aug 23 10:07:33 2021(D0): RemoveFromQueue(1)", -- [60]
"Mon Aug 23 10:07:33 2021(D0): AdjustInventory()", -- [61]
"Mon Aug 23 10:07:33 2021(D0): ScanQueuedReagents()", -- [62]
"Mon Aug 23 10:07:33 2021(D0): CalculateCraftableCounts()", -- [63]
"Mon Aug 23 10:07:33 2021(D0): GetTradeSkillLevels(141323, 188802)", -- [64]
"Mon Aug 23 10:07:33 2021(D0): GetTradeSkillLevels: levels= 1/20/50/80", -- [65]
"Mon Aug 23 10:07:33 2021(D0): UpdateIgnoredMatsButton()", -- [66]
"Mon Aug 23 10:07:33 2021(D0): GetIgnoreList(nil)", -- [67]
"Mon Aug 23 10:07:33 2021(D0): Ignored Mats list for: all players", -- [68]
...
"Mon Aug 23 10:07:33 2021(D0): GetTradeSkillLevels(141323, 188802)", -- [79]
"Mon Aug 23 10:07:33 2021(D0): GetTradeSkillLevels: levels= 1/20/50/80", -- [80]
"Mon Aug 23 10:07:33 2021(T): UNIT_SPELLCAST_STOP(player, Cast-3-3111-1220-20371-188802-0000236551, 188802, nil, nil)", -- [81]
"Mon Aug 23 10:07:33 2021(D4): IgnoreCast(188802), Wild Transmutation", -- [82]
"Mon Aug 23 10:07:33 2021(T): BAG_UPDATE( 0 )", -- [83]
"Mon Aug 23 10:07:33 2021(T): BAG_UPDATE( 0 )", -- [84]
"Mon Aug 23 10:07:33 2021(T): BAG_UPDATE( 0 )", -- [85]
"Mon Aug 23 10:07:33 2021(T): BAG_UPDATE( 0 )", -- [86]
"Mon Aug 23 10:07:33 2021(T): BAG_UPDATE( 0 )", -- [87]
"Mon Aug 23 10:07:33 2021(T): BAG_UPDATE( 10 )", -- [88]
"Mon Aug 23 10:07:33 2021(T): BAG_UPDATE( 11 )", -- [89]
"Mon Aug 23 10:07:33 2021(T): BAG_UPDATE( 11 )", -- [90]
"Mon Aug 23 10:07:33 2021(T): BAG_UPDATE( 0 )", -- [91]
"Mon Aug 23 10:07:33 2021(T): TRADE_SKILL_LIST_UPDATE", -- [92]
b-morgan commented 2 years ago

Thank you for the debug output. There are some strange events associated with Wild Transmutation but it looks like Skillet is handling them correctly now. I'll publish 4.35 with this fix.