b-morgan / Skillet

World of Warcraft addon
GNU General Public License v3.0
14 stars 5 forks source link

Auctionator price info now showing #6

Closed DonSerrot closed 3 years ago

DonSerrot commented 3 years ago

The last working version I found was 4.20 where the Auctionator pricing info showed. I actually literally just put the 4.20 version of Auctionator.lua from the Plugins folder into the 4.24 Plugins folder and it works again. Not sure what changed and I don't have a good way to compare the code myself (or an understanding of lua to begin with) to pinpoint where the problem is other than with the Auctionator plugin itself. So far I haven't seen any errors with the old plugin, but it's only been a few minutes of trying it on a whim.

b-morgan commented 3 years ago

The Auctionator plugin in 4.24 is working for me. The 4.24 version has some new features which are controlled by some new options so you might want to check your options (or compare options with the 4.20 version with the 4.24 version).

DonSerrot commented 3 years ago

That was the problem. I had showProfitValue turned off for some reason.

b-morgan commented 3 years ago

You didn't have showProfitValue turned off because that was a new option added after 4.20 :smile: Perhaps the default value of that option should be true for upwards compatibility.

DonSerrot commented 3 years ago

Having it default to on would certainly help prevent confusion. 😉

b-morgan commented 3 years ago

Next release will have an option something like "Always show headers with progress bars" and the default for showProfitValue will be true. Maybe I'll even get the Mining "bug" fixed.