b-morgan / Skillet

World of Warcraft addon
GNU General Public License v3.0
15 stars 6 forks source link

Error trying to enchant multiple items #73

Closed Fagerinfoco closed 1 year ago

Fagerinfoco commented 1 year ago

<Please include the Skillet version number (from the title or the .toc file)> Version: 5.02 <Please include the output of "/dump GetLocale()" if it is different than enUS>

Attempting to make multiple enchants via the Blizzard UI, as I was unable to create via Skillet. Receive the following error: Message: Interface/AddOns/Skillet/UI/FinishingList.lua:290: attempt to index local 'thisFinishing' (a nil value) Time: Tue Jan 3 13:47:49 2023 Count: 1 Stack: Interface/AddOns/Skillet/UI/FinishingList.lua:290: attempt to index local 'thisFinishing' (a nil value)

Locals: self = SkilletReagent1 { 0 = } button = "LeftButton" down = false link = "[Chromatic Dust]"

b-morgan commented 1 year ago

I'm not sure I understand what caused the error... Did you attempt to make multiple enchants with Skillet and it failed with the error or did you attempt to make multiple enchants via the Blizzard UI and you got the error from Skillet?

My Enchanter is level 50 so I haven't been able to do any Dragonflight Enchanting specific debugging.

Skillet 5.02 doesn't do well with crafting multiples of anything (i.e. any profession) with modified (multiple quality) reagents. Skillet 5.03-alpha2 converts crafting multiples of recipes with modified reagents into a series of single crafts. One of the issues with these recipes is that making 2 or more of something may use a different mix (i.e. different qualities) of the modified reagents for each iteration of the recipe. I've written the code to handle this but I don't believe all of the possible cases have been tested.

Please upload a screenshot of Skillet just before you get the error and show/tell me what you clicked to generate the error.

None of my characters have unlocked any Finishing reagents although the code to handle them is ignoring the locked state for now. I don't know if that is causing your error. I will probably need you to enable the debugging code so I can get some insight into what might be causing the issue.

b-morgan commented 1 year ago

Skillet-5.03-alpha3 will give Enchants from any expansion a fighting chance of working. I still can't test Dragon Isles Enchants directly and I'll probably find more bugs when I try to enchant scrolls but let me know if this gets any closer to working for you.

b-morgan commented 1 year ago

Unless Blizzard did something to change Enchanting Vellum in Dragonflight, Skillet will direct an Enchant to Enchanting Vellum the same way it always has, right-click Create or Process.

Fagerinfoco commented 1 year ago

Ok, have not moved to the alpha release yet, but here’s some information that may help.

On the skillet screen, when I click create or process (right or left click),the pointer does not have the blue highlighting as previous versions did.

When I switch to the blizzard UI, it does not process multiple but it does allow me to do one at a time. Error appears to be intermittent

b-morgan commented 1 year ago

The behavior you observe in Skillet 5.02 is entirely consistent with the code. Basically, enchants are ignored. Skillet 5.03-alpha3 no longer ignores enchants but treats them identically with all other profession recipes with the exception that enchanting vellum can be used directly (as opposed to applying the blue highlighted cursor to vellum in your inventory).

I'm afraid I don't know how the Blizzard UI is supposed to function for Dragon Isles enchants. I'll do some quick testing on Shadowlands enchants to see if anything unusual occurs.

Please move to the latest alpha release as soon as possible.

b-morgan commented 1 year ago

Latest alpha is here.

b-morgan commented 1 year ago

This issue was reported against Skillet 5.02 which didn't process Enchants at all. Please open a new issue if problems are encountered in newer versions.