search

b-morgan / Skillet

World of Warcraft addon
GNU General Public License v3.0
14 stars 5 forks source link

Skillet conflicts with addon All the Things #8

Closed ishirra closed 3 years ago

ishirra commented 3 years ago

I am using version 4.24 (image says 4.22 but it was taken before I updated the addon) I have addon All The Things, it gives a window next to the crafting window, to see which recipes I can still get etc. When Skillet is turned off the window does what it's supposed to do, when Skillet is loaded the window is stuck in the middle of my screen, unmovable and blocking my view and it stops me from being able to click things

image

b-morgan commented 3 years ago

Skillet doesn't cause this behavior, All The Things attaches its frame to Blizzard's (hidden and unmovable) TradeSkillFrame (Skillet IS responsible for hiding the Blizzard TradeSkillFrame). The following change to AllTheThings.lua starting at line 14901 will get you most of the way there.

            elseif SkilletFrame then
                self:SetPoint("TOPLEFT", SkilletFrame, "TOPRIGHT", 0, 0);
                self:SetPoint("BOTTOMLEFT", SkilletFrame, "BOTTOMRIGHT", 0, 0);
                self:SetMovable(true);
            elseif TradeSkillFrame then
                -- Default Alignment on the WoW UI.
                self:SetPoint("TOPLEFT", TradeSkillFrame, "TOPRIGHT", 0, 0);
                self:SetPoint("BOTTOMLEFT", TradeSkillFrame, "BOTTOMRIGHT", 0, 0);
                self:SetMovable(false);

https://github.com/DFortun81/AllTheThings/issues/705#issuecomment-783283024