b-morgan / Skillet

World of Warcraft addon
GNU General Public License v3.0
15 stars 6 forks source link

Error retrieving mats from Guild Bank #84

Closed Fagerinfoco closed 1 year ago

Fagerinfoco commented 1 year ago

Version 5.06 When trying to retrieve items from the guild bank,it retrieves a single item then i get this error:

Message: Interface/AddOns/Skillet/UI/ShoppingList.lua:577: attempt to call global 'processGuildQueue' (a nil value) Time: Sun Feb 12 15:22:52 2023 Count: 1 Stack: Interface/AddOns/Skillet/UI/ShoppingList.lua:577: attempt to call global 'processGuildQueue' (a nil value)

[string "@Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...ings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function `Fire' [string "@Interface/AddOns/DataStore/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <.../AddOns/DataStore/libs/AceEvent-3.0/AceEvent-3.0.lua:119>

Locals: (*temporary) = defined =[C]:-1

b-morgan commented 1 year ago

This is fixed in Skillet-5.07.

stmides commented 1 year ago

Version 5.07

Message: Interface/AddOns/Skillet/UI/ShoppingList.lua:1064: attempt to index global 'modifiedInQueue' (a nil value) Time: Mon Feb 13 11:34:21 2023 Count: 1 Stack: Interface/AddOns/Skillet/UI/ShoppingList.lua:1064: attempt to index global 'modifiedInQueue' (a nil value) [string "@Interface/AddOns/Skillet/UI/ShoppingList.lua"]:1064: in function `GetReagentsFromBanks'

Locals: self =

{ DeleteIgnoreEntry = defined @Interface/AddOns/Skillet/UI/IgnoreList.lua:170 VendorItemAvailable = defined @Interface/AddOns/Skillet/Inventory.lua:305 SkillButton_NewGroup = defined @Interface/AddOns/Skillet/UI/MainFrame.lua:1889 guildText = 7 ClearQueue = defined @Interface/AddOns/Skillet/SkilletQueue.lua:291 RecipeGroupInitFlatten = defined @Interface/AddOns/Skillet/RecipeGroups.lua:362 MERCHANT_UPDATE = defined @Interface/AddOns/Skillet/UI/MerchantWindow.lua:209 SkilletShow = defined @Interface/AddOns/Skillet/Skillet.lua:1244 DisplayShoppingList = defined @Interface/AddOns/Skillet/UI/ShoppingList.lua:1316 ShowQueueView = defined @Interface/AddOns/Skillet/UI/MainFrame.lua:2942 ReagentStarsFrame_OnMouseEnter = defined @Interface/AddOns/Skillet/UI/DetailFrame.lua:1286 SKILL_LINES_CHANGED = defined @Interface/AddOns/Skillet/Skillet.lua:913 SetSelectedTrade = defined @Interface/AddOns/Skillet/Skillet.lua:1575 FilterDropDown_OnShow = defined @Interface/AddOns/Skillet/UI/Filtering.lua:25 GARRISON_TRADESKILL_NPC_CLOSED = defined @Interface/AddOns/Skillet/Skillet.lua:1034 hideTrivialRecipes = false SetTradeSkillLearned = defined @Interface/AddOns/Skillet/SkilletData.lua:228 guildbankQueryComplete = defined @Interface/AddOns/Skillet/UI/ShoppingList.lua:836 RecipeGroupSort = defined @Interface/AddOns/Skillet/RecipeGroups.lua:340 EnableResize = defined @Interface/AddOns/Skillet/UI/Utils.lua:74 db =
{ } bankBusy = false UpdateNotesWindow = defined @Interface/AddOns/Skillet/UI/RecipeNotes.lua:116 SetEnabledState = defined @Interface/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:420 SkilletShowWindow = defined @Interface/AddOns/Skillet/Skillet.lua:1304 AdditionalButtonsList =
{ } CHAT = defined @Interface/AddOns/Skillet/DebugAids.lua:83 HideOptionalList = defined @Interface/AddOns/Skillet/UI/OptionalList.lua:263 IgnoreList_OnScroll = defined @Interface/AddOns/Skillet/UI/IgnoreList.lua:288 SortDropdown_OnLoad = defined @Interface/AddOns/Skillet/UI/Sorting.lua:492 pluginsOptions =
{ } TRADE_SKILL_ITEM_CRAFTED_RESULT = defined @Interface/AddOns/Skillet/SkilletQueue.lua:825 NewModule = defined @Interface/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:231 RecipeGroupFlatten = defined @Interface/AddOns/Skillet/RecipeGroups.lua:378 RecipeGroupMoveEntry = defined @Interface/AddOns/Skillet/RecipeGroups.lua:237 FavoriteButton_OnClick = defined @Interface/AddOns/Skillet/UI/MainFrame.lua:1968 RegisterProcessQueuePlugin = defined @Interface/AddOns/Skillet/SkilletPlugin.lua:148 ReagentButtonSkillSelect = defined @Interface/AddOns/Skillet/UI/DetailFrame.lua:1048 ITEM_DATA_LOAD_RESULT = defined @Interface/AddOns/Skillet/Skillet.lua:1038 ShowReagentDetails = defined @Interface/AddOns/Skillet/UI/MainFrame.lua:968 bopCheck = defined @Interface/AddOns/Skillet/UI/MainFrame.lua:1679 RecipeGroupClearEntries = defined @Interface/AddOns/Skillet/RecipeGroups.lua:107 Disable = defined @Interface/AddOns/AdiBags/libs/AceAddon-3.0/AceAddon-3.0.lua:310 TABLE = defined @Interface/AddOns/Skillet/Debu

b-morgan commented 1 year ago

Replace ...\Addons\Skillet\UI\ShoppingList.lua with the one in this zip file. This should eliminate the lua error.

There are still cases where Skillet gets confused by items with multiple qualities. This is especially true with Engineering. For example, if you have multiple qualities in the bank, this code fetches the needed quantity of each, i.e. if you need 4 Serevite ore and you have some Q1 and some Q2 ore in the bank, you will get 8 ore in your bags.

ShoppingList.zip

Let me know what profession(s) you are using and with what cases does Skillet surprise you with its decisions.

b-morgan commented 1 year ago

You can use Skillet-5.08-alpha1 instead.

stmides commented 1 year ago

Will try the alpha build.

On the character that was getting the errors I have Jewlcrafting and Engineering. The error was on a JC craft.