b-morgan / Skillet

World of Warcraft addon
GNU General Public License v3.0
15 stars 6 forks source link

Skillet.lua:140: attempt to index global 'ProfessionsFrame' (a nil value) #89

Closed Thrumbar closed 1 year ago

Thrumbar commented 1 year ago

This error pops on first opening. Also the default trade skill frame opens and not the skillet one.

<Skillet version number (5.22)

2x Skillet/Skillet.lua:140: attempt to index global 'ProfessionsFrame' (a nil value) [string "@Skillet/Skillet.lua"]:140: in function `DisableBlizzardFrame' [string "@Skillet/Skillet.lua"]:1297: in function `SkilletShow' [string "@Skillet/Skillet.lua"]:974: in function `?' [string "@DataStore/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:109: in function <...ore/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:109> [string "=[C]"]: ? [string "@DataStore/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:19: in function <...ore/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@DataStore/libs/CallbackHandler-1.0-8/CallbackHandler-1.0.lua"]:54: in function `Fire' [string "@DataStore/libs/AceEvent-3.0-4/AceEvent-3.0.lua"]:120: in function [string "=[C]"]: in function `OpenTradeSkill' [string "@Molinari/hack.lua"]:61: in function Locals: self = { DeleteIgnoreEntry = defined @Skillet/UI/IgnoreList.lua:170 VendorItemAvailable = defined @Skillet/Inventory.lua:305 SkillButton_NewGroup = defined @Skillet/UI/MainFrame.lua:1901 guildText = 0 ClearQueue = defined @Skillet/SkilletQueue.lua:316 RecipeGroupInitFlatten = defined @Skillet/RecipeGroups.lua:362 MERCHANT_UPDATE = defined @Skillet/UI/MerchantWindow.lua:209 SkilletShow = defined @Skillet/Skillet.lua:1256 DisplayShoppingList = defined @Skillet/UI/ShoppingList.lua:1320 ShowQueueView = defined @Skillet/UI/MainFrame.lua:2954 ReagentStarsFrame_OnMouseEnter = defined @Skillet/UI/DetailFrame.lua:1430 SKILL_LINES_CHANGED = defined @Skillet/Skillet.lua:925 SetSelectedTrade = defined @Skillet/Skillet.lua:1587 FilterDropDown_OnShow = defined @Skillet/UI/Filtering.lua:25 GARRISON_TRADESKILL_NPC_CLOSED = defined @Skillet/Skillet.lua:1046 hideTrivialRecipes = false SetTradeSkillLearned = defined @Skillet/SkilletData.lua:228 guildbankQueryComplete = defined @Skillet/UI/ShoppingList.lua:839 RecipeGroupSort = defined @Skillet/RecipeGroups.lua:340 EnableResize = defined @Skillet/UI/Utils.lua:74 db =
{ } InitializeSkillLevels = defined @Skillet/SkillLevelData.lua:253 UpdateNotesWindow = defined @Skillet/UI/RecipeNotes.lua:116 interface = 100107 SetEnabledState = defined @DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:420 SkilletShowWindow = defined @Skillet/Skillet.lua:1316 CHAT = defined @Skillet/DebugAids.lua:83 HideOptionalList = defined @Skillet/UI/OptionalList.lua:263 IgnoreList_OnScroll = defined @Skillet/UI/IgnoreList.lua:288 SortDropdown_OnLoad = defined @Skillet/UI/Sorting.lua:491 pluginsOptions =
{ } TRADE_SKILL_ITEM_CRAFTED_RESULT = defined @Skillet/SkilletQueue.lua:943 NewModule = defined @DataStore/libs/AceAddon-3.0/AceAddon-3.0.lua:231 RecipeGroupFlatten = defined @Skillet/RecipeGroups.lua:378 FinishChange = defined @Skillet/Skillet.lua:1466 FavoriteButton_OnClick = defined @Skillet/UI/MainFrame.lua:1980 RegisterProcessQueuePlugin = defined @Skillet/SkilletPlugin.lua:148 ReagentButtonSkillSelect = defined @Skillet/UI/DetailFrame.lua:1178 RequiredListToggleHaveItems = defined @Skillet/UI/RequiredList.lua:24 ITEM_DATA_LOAD_RESULT = defined @Skillet/Skillet.lua:1050 ShowReagentDetails = defined @Skillet/UI/MainFrame.lua:972 bopCheck = defined @Skillet/UI/MainFrame.lua:1691 RecipeGroupClearEntries = defined @Skillet/RecipeGroups.lua:107 PrintSaved = defined @Skillet/SkilletQueue.lua:332 TABLE = defined @Skillet/DebugAids.lua:352 FixBugs = true Unhook = defined @Decursive/Libs/AceHook-3.0/AceHook-3.0.lua:417 InventoryFilterButton_OnShow = defined @Skillet/UI/MainFrame.lua:2266 SetTradeSkillToolTip = defined @Skillet/UI/MainFrame.lua:1646 LEARNED_SPELL_IN_TAB = defined @Skillet/Skillet.lua:934 ToggleTradeSkillOption = defi
b-morgan commented 1 year ago

I cannot reproduce this error. I do notice that the addon Molinari is referenced in the traceback and that addon doesn't appear to be updated for 10.1.7 so I'd like you to disable that addon and see if the problem goes away.

b-morgan commented 1 year ago

I installed the addon Molinari (and checked "Load out of date AddOns") and Skillet is still working for me.

Please verify that your install is not corrupt by downloading (and installing) from https://legacy.curseforge.com/wow/addons/skillet/files and verifying the MD5.

You might also uncheck "Load out of date AddOns" to see if some other addon is causing the issue.

If it is still failing, I will need your global saved variables file Skillet.lua and your character specific saved variables file Skillet.lua. You can zip them together if you rename one of them.

b-morgan commented 1 year ago

So I tabbed out of WoW to type the above comment and when I returned to WoW, I'm getting this error. I'll get back to you when I figure out what went wrong.

b-morgan commented 1 year ago

I tried for an hour on all of my toons with professions and it never happened again so I don't know what to say.

Thrumbar commented 1 year ago

Made some changes and stopped my errors..

function Skillet:DisableBlizzardFrame() DA.DEBUG(0, "DisableBlizzardFrame()")

if not ProfessionsFrame then
    DA.DEBUG(0, "ProfessionsFrame is nil!")
    return
end

if not self.BlizzardTradeSkillFrame then
    self.BlizzardTradeSkillFrame = ProfessionsFrame
    self.tradeSkillHide = ProfessionsFrame:GetScript("OnHide")

     ProfessionsFrame:SetScript("OnHide", nil)

 end

if self.interface < 100100 then
    SetUIPanelAttribute(ProfessionsFrame, "width", 0) -- Prevent AH from closing when Skillet is opened.
end

 HideUIPanel(ProfessionsFrame)

self.BlizzardUIshowing = false

end

Will continue to test and watch..

b-morgan commented 1 year ago

I have added similar code to the next release.