search

b-morgan / Skillet

World of Warcraft addon
GNU General Public License v3.0
14 stars 5 forks source link

Error when queueing items with overlapping prerequisites #91

Closed Erstyx closed 6 months ago

Erstyx commented 7 months ago

<Please include the Skillet version number (from the title or the .toc file)> 5.2.3

Scenario: I'm queueing up a bunch of items so I can make a single trip to the AH before crafting.

Repro steps: 1) Queue an item like Engineering:Tankatronic Goggles. Note that you see 1 Khorium Power Core, 2 Hardened Adamantite Tube, 4 Felsteel Stabilizer and then 1 Tankatronic Goggles in the queue. 2) Queue an item with overlapping prerequisites, like Engineering:Surestrike Goggles V2.0.

Actual behavior: Surestrike Goggles is added to the end of the queue with no other changes. Expected behavior: As above, but prerequisites are appropriately incremented (2 Khorium Power Core, 4 Hardened Adamantite Tube, 8 Felsteel Stabilizer)

b-morgan commented 7 months ago

You can solve this issue by changing line 96 in SkilletQueue.lua from: have = numInBoth + (reagentsInQueue[reagentID] or 0) to: have = numInBoth I haven't tested other cases (i.e. does this break anything else) so I probably should add an option.

Let me know if this works or not.

Erstyx commented 7 months ago

Yes, this has been working for me. Thanks!

b-morgan commented 6 months ago

Skillet-5.24 contains an option to control this behavior.