Closed nyurik closed 2 years ago
Wow, thanks for implementing that!
I still need a little time to look into the code first, but I like that you even included a test file.
I think it's okay to not return an Option
if it just returns an empty iterator if the feature is not active.
Sure thing, let me know how i can help with the review. There is a GeoRust discord channel you may want to join, or OSM-US Slack -- lots of fun OSM & Rust related discussions :)
There is an optional feature
LocationsOnWays
available on OSM PBF files. It can be generated with osmium add-locations-to-ways ..., initially described here, and documented at osm wiki.This PR implement support for this feature in the same way as
way.refs()
.Should
nodes()
return None if the file has noLocationsOnWays
set?