Montage-3103b.v2 suggestion: avoid dev_err on address detection

b-rad-NDi / media_tree

Upstream media tree -- WARNING I REBASE MY BRANCHES

https://linuxtv.org

Other

2 stars 3 forks source link

Montage-3103b.v2 suggestion: avoid dev_err on address detection #10

Closed JMS-1 closed 4 years ago

JMS-1 commented 4 years ago

With kernel 5.7 in each boot you find the "errror" message: m88ds3103 5-006a: dt addr is 0x21

I think your use of dvb_err is unintentional and perhaps you should lower the severity a bit: _dev_err(&client->dev, "dt addr is 0x%02x", dev->dtaddr); [drivers/media/dvb-frontends/m88ds3103.c line 1904].

In addition your fix still works like a charm!

micha137 commented 4 years ago

Yes, sorry. Someone already fixed this here: https://git.linuxtv.org/media_tree.git/commit/?id=c77591a8ca5ad843238df67f89a1bdc0ee7dbb76