search

b-rodrigues / rap4all

https://raps-with-r.dev/
Other
96 stars 31 forks source link

Changed potential typo #41

Closed JT-39 closed 1 year ago

JT-39 commented 1 year ago

Hi Bruno,

I have found a small potential typo in Chapter 6 Functional Programming, 6.2 Writing good functions, 6.2.1 Functions are first-class objects. You give examples of both sqrt(-5) and sqrt(-10) lead to warnings NaNs produced. I wondered if the second should have been log10(-10) instead?

Also, in 6.2.4 Recursive functions. You include i = i +1 in the iterative function and I am not sure the reason? I believe the function works fine without?

This is my first pull request so apologies for being so pedantic but I wanted to try it out also!

Thanks, Jake

b-rodrigues commented 1 year ago

Hi Jake

many thanks for your PR! I'm currently on holidays so I won't be able to look at this immediately, but will do so on my return! I'll leave the PR open until then (next Friday or Saturday)

Cheers

Sent from ProtonMail mobile

-------- Original Message -------- On Sep 1, 2023, 21:19, JT-39 wrote:

Hi Bruno,

I have found a small potential typo in Chapter 6 Functional Programming, 6.2 Writing good functions, 6.2.1 Functions are first-class objects. You give examples of both sqrt(-5) and sqrt(-10) lead to warnings NaNs produced. I wondered if the second should have been log10(-10) instead?

Also, in 6.2.4 Recursive functions. You include i = i +1 in the iterative function and I am not sure the reason? I believe the function works fine without?

This is my first pull request so apologies for being so pedantic but I wanted to try it out also!

Thanks, Jake

You can view, comment on, or merge this pull request online at:

https://github.com/b-rodrigues/rap4all/pull/41

Commit Summary

File Changes

(1 file)

Patch Links:

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

b-rodrigues commented 1 year ago

all the other changes are ok!

JT-39 commented 1 year ago

Are you sure about the table position change? I think that "1" is correct, but I’ll have to test later tonight.

I am pretty sure... I had to change it from table pos 1 as it was picking up something other than the communes (This article does not cite any sources. Please help improve this article by adding citations to reliable sources. Unsourced material may be challenged and removed.Find sources: "List of communes of Luxembourg" – news · newspapers · books · scholar · JSTOR (September 2023) (Learn how and when to remove this template message)).

I an using a Mac though.

b-rodrigues commented 1 year ago

Many thanks! Changing the table's position was indeed the right thing to do. What happened is that the wikipedia page got edited since I had written that part. So this time I re-hosted a snapshot of the page and scrape it from there.