b-rodrigues / rix

Reproducible development environments for R with Nix
https://b-rodrigues.github.io/rix/
GNU General Public License v3.0
102 stars 11 forks source link

Remove {httr} and replace with already used {curl} dependency #183

Closed philipp-baumann closed 4 days ago

philipp-baumann commented 2 weeks ago

There is two functions where we do http(s) requests via {httr}

It's quite straightforward and safe to do this directly with low-level curl::curl_fetch_memory() and appropriate error handle. I can make a PR, so we can get rid of httr and have even less dependencies.

philipp-baumann commented 2 weeks ago

model it after here: https://cran.r-project.org/web/packages/curl/vignettes/intro.html

philipp-baumann commented 1 week ago

addressing it in #189

philipp-baumann commented 4 days ago

closing, addressed in #189