search

b-thorne / PySM_public

PySM: Software for simulating the Galactic microwave sky
24 stars 29 forks source link

Dust temperature can't be scalar #35

Closed susannaaz closed 5 years ago

susannaaz commented 5 years ago

Cell 13 in the example notebook (https://github.com/bthorne93/PySM_public/blob/master/example.ipynb) seems to suggest that one could make all spectral parameters of a given component scalars instead of maps. This however seems to work only for spectral indices, not for e.g. dust temperature (the code will crash if you replace 'spectral_index' with 'temp' in that same cell)

I also think some aspects of the example notebooks are outdated (e.g. bare 'print' statements a la python2.7)

zonca commented 5 years ago

thanks for your feedback. yes, correct, you need to create an array. we are focusing now on the development of PySM 3, still work in progress at https://github.com/healpy/pysm so won't develop any improvements on PySM 2, just bugfixes. as for the print statement, if you want to provide a pull request, I'll be happy to merge it.