search

b-yond-infinite-network / jest-cucumber-fusion

Write cucumber test the natural way but still have them part of a jest run (including coverage)
Apache License 2.0
15 stars 8 forks source link

language support #15

Closed stevensnoeijen closed 3 years ago

stevensnoeijen commented 4 years ago

I'm trying to add tests in another language (than english) but this doesn't work. I dived in this problem and came to the conclusion that this should be fixed in jest-cucumber: https://github.com/bencompton/jest-cucumber/issues/107

Any thoughts?

bruno-morel commented 3 years ago

That would be great indeed. Can you give example of what your trying to achieve so that we can write test to be ready when jest-cucumber supports it?

stevensnoeijen commented 3 years ago

Sorry, didnt see your comment. Ill pick this up very soon!

tetrox commented 3 years ago

@stevensnoeijen I thik we need trow lang code from jest-cucumber. if we up version at 3.0.1, jest-cucumber will return correctly steps, but don't know lang code.

stevensnoeijen commented 3 years ago

If we use 3.0.1 language would also be supported 😛. I'll create a PR this weekend

stevensnoeijen commented 3 years ago

working on it: https://github.com/stevensnoeijen/jest-cucumber-fusion/tree/upgrade_jest-cucumber_to_v3

stevensnoeijen commented 3 years ago

There is an issue in the language support for jest-cucumber, i'll be fixing that first before continuing on this

stevensnoeijen commented 3 years ago

I created a PR on https://github.com/bencompton/jest-cucumber/pull/119 that should fix the issue I'm facing with my current test, some steps weren't correctly translated due to an error in the translation.

stevensnoeijen commented 3 years ago

PR in jest-cucumber is merged and i'll continue on this after there is a new releases for jest-cucumber.

bruno-morel commented 3 years ago

excellent. need any help other than reviewing it when you're ready with the code?

stevensnoeijen commented 3 years ago

nope, dev on jest-cucumber is going well, so hopefully we can add this feature soon :)

stevensnoeijen commented 3 years ago

created a PR;https://github.com/b-yond-infinite-network/jest-cucumber-fusion/pull/22 . I did it anyway because waiting on a new release from jest-cucumber might take longer than I thought. And this should work anyways (excluding some language bugs, you can read about them at https://github.com/bencompton/jest-cucumber/pull/123).

stevensnoeijen commented 3 years ago

added in v0.8.0