search

b-yond-infinite-network / jest-cucumber-fusion

Write cucumber test the natural way but still have them part of a jest run (including coverage)
Apache License 2.0
15 stars 8 forks source link

Fix issue related to incorrect parsing examples in Scenario Outline steps #28

Closed j8kin closed 3 years ago

j8kin commented 3 years ago

Fixes #27

codecov[bot] commented 3 years ago

Codecov Report

Merging #28 (eca703e) into master (6b53166) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          123        97   -26     
  Branches        28        24    -4     
=========================================
- Hits           123        97   -26
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b53166...eca703e. Read the comment docs.

j8kin commented 3 years ago

@bruno-morel I've think a little about uncovered code and it seems it is not necessary and we could delete it: isPotentialStepFunctionForScenario and related functions. As I understand this code it is created to replace outline variables with it's values in steps. But now it is supported out of the box by jest-cucumber (see my changes related to: currentScenarioOrOutline.scenarios[0].steps).

So if you confirm I code also remove all unnecessary code by this PR. Please take a look and provide your opinion.

Eugene... P.S. I've remove this code by this PR on my last commits

j8kin commented 3 years ago

@bruno-morel could you take a look on this PR. It is quite urgent we stuck with test development because of it. @albertaouad Albert, could you take a look into this PR or find someone who could review -> approve and then publish new version in npm repository?

bruno-morel commented 3 years ago

sorry those notification have been missed