b-yond-infinite-network / jest-cucumber-fusion

Write cucumber test the natural way but still have them part of a jest run (including coverage)
Apache License 2.0
15 stars 8 forks source link

Add TypeScript definitions #6

Closed pjoe closed 4 years ago

pjoe commented 4 years ago

Adds definition file for TypeScript 🎨

codecov[bot] commented 4 years ago

Codecov Report

Merging #6 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files           1        1           
  Lines         104      104           
  Branches       26       26           
=======================================
  Hits          102      102           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a8f33b...52828d0. Read the comment docs.

pjoe commented 4 years ago

FYI: I also tried adding to https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43487

bruno-morel commented 4 years ago

Tks, amazing job! I'll merge it

bruno-morel commented 4 years ago

Now that its merged, do you think we should add a documentation example for this? @pjoe

pjoe commented 4 years ago

@bruno-morel yeah an example in docs would be good - will see if I can find some time to do a PR for that.

Also once released (is it already in 0.6.4?), then I guess the typings should be removed from DefinitelyTyped.

Btw. thanks for this great lib, makes adopting cucumber super smooth :)

bruno-morel commented 4 years ago

Yes it's already in 0.6.4. I bumped some libs too since there was an advisory.

Tks, unsurprisingly I made it for myself to not fight between jest and cucumber :)

Happy you found it and enjoy it!

Don't hesitate to PR the doc!

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 0.6.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: