b-yp / logseq-insert-movie-properties

A plugin that can insert movie information in Logseq
MIT License
7 stars 0 forks source link

TV series - how to add based on the tt code? #14

Closed TigBuh99 closed 1 year ago

TigBuh99 commented 1 year ago

I tried adding a TV series based on its title, as per usual, but I wasn't successful. Specifically, I wanted to add Masterchef, the UK version. I chose this one because there are many similarly named series worldwide and I think that it was a good test. This one has the IMDB code tt0805418 and the title on the IMDB website is "Masterchef Goes Large". The plugin doesn't find it.

Can we add a TV series based on the tt code as input?

b-yp commented 1 year ago

The plugin uses the TMDB API, but I couldn't find this TV show on the official TMDB website.

TMDB: https://www.themoviedb.org/

TigBuh99 commented 1 year ago

It's this one: https://www.themoviedb.org/tv/25992-masterchef-goes-large :)

Probably the 25992 is a unique code?

b-yp commented 1 year ago

This is currently a flaw in the plugin. The same name may correspond to multiple TV shows or movies, but the plugin defaults to the first result. As a result, some TV shows or movies may never be found (because they may not be ranked first). The next step for the plugin is to return search results in the form of a list for users to choose from, so that they can select the correct one.

TigBuh99 commented 1 year ago

I agree. I saw something similar to what you say in Obsidian where the input returns a list of Films or TV series and the user picks what he/she wants.

b-yp commented 1 year ago

Yes, this task may be completed within this week.

TigBuh99 commented 1 year ago

Thank you for your paying attention to it. This plugin is going to become one of my favorite plugins in Logseq!!

b-yp commented 1 year ago

Thank you very much for your affirmation. It is also one of my motivations for writing this plugin ❤.

b-yp commented 1 year ago

I just released a version, added the functionality of list selection. image

TigBuh99 commented 1 year ago

I haven't tested much, but from what I've seen it exceeds my expectations. Excellent work indeed!

b-yp commented 1 year ago

Thank you, I have only implemented the functionality temporarily, the style still needs to be optimized, and it needs to be compatible with light and dark themes.