b-zurg / react-collapse-pane

The splittable, draggable, collapsible panel layout library 🎉
https://storybook-collapse-pane.netlify.app/
MIT License
210 stars 35 forks source link

Missing definition for Nullable<T> in SplitPane/index.tsx #24

Closed hst44 closed 4 years ago

hst44 commented 4 years ago

Nullable is not defined in src/components/SplitPane/index.tsx which causes builds to fail when including a SplitPane via npm. Results in:

ERROR in ...\node_modules\react-collapse-pane\dist\components\SplitPane\index.d.ts (8,35): error TS2304: Cannot find name 'Nullable'. ERROR in ...\node_modules\react-collapse-pane\dist\components\SplitPane\index.d.ts (34,22): error TS2304: Cannot find name 'Nullable'.

b-zurg commented 4 years ago

Oh! That's what I get for using a global type.

I'll fix that today. I think you should be able to get it working by using skiplibcheck in the tsconfig.json of your project.

github-actions[bot] commented 4 years ago

:tada: This issue has been resolved in version 1.3.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

b-zurg commented 4 years ago

@hst44 did the latest release resolve the issue?

hst44 commented 4 years ago

There isnt an error about Nullable anymore, but the change introduced a new error:

ERROR in ...\node_modules\react-collapse-pane\dist\components\SplitPane\index.d.ts (2,26): error TS2307: Cannot find module '../../types/utilities' or its corresponding type declarations.

b-zurg commented 4 years ago

Thanks for reporting. The source of this issue was that *.d.ts files are not emitted during output. I'll rename the type declaration file to be a normal *.ts file and have a fix released in a sec.

hst44 commented 4 years ago

Great! thanks for the quick fix!

b-zurg commented 4 years ago

No worries :)

@all-contributors please add @hst44 for bug

allcontributors[bot] commented 4 years ago

@b-zurg

I've put up a pull request to add @hst44! :tada:

b-zurg commented 4 years ago

Release v1.3.10

Please confirm if it fixes the issue

hst44 commented 4 years ago

All fixed. Thanks!