search

b01 / dl-vscode-server

MIT License
20 stars 4 forks source link

Missing Argument Specification for BUILD Parameter in dl-vscode-server Script #18

Closed shivarajd closed 3 days ago

shivarajd commented 3 months ago

There is no value specified (nor can it be specified during execution) in the dl-vscode-server.sh script for the BUILD argument used in the command: curl -s --fail -L "https://update.code.visualstudio.com/commit:${commit_sha}/server-${PLATFORM}-${ARCH}/${BUILD}" -o "/tmp/${archive}"

b01 commented 2 months ago

Its default is set at line https://github.com/b01/dl-vscode-server/blob/f5c49fccdd156f429cf272ceb2a85cdad2cd5ad6/download-vs-code.sh#L131

There are only 2 possible values, so there is an Boolean option to set it to --insider, see lines https://github.com/b01/dl-vscode-server/blob/f5c49fccdd156f429cf272ceb2a85cdad2cd5ad6/download-vs-code.sh#L140-L141

I need to improve how you can set options, they are bit finicky right now.

b01 commented 3 weeks ago

I've made changes in release 0,2.1 to better handle options passed in from the command.

b01 commented 3 weeks ago

So if you used the script https://github.com/b01/dl-vscode-server/blob/main/download-vs-code.sh. You should be able o set it.

@shivarajd Will that work?

b01 commented 3 days ago

This should be resolved. Please re-open if you find that it has not been.