search

b0o / SchemaStore.nvim

🛍 JSON schemas for Neovim
https://schemastore.org
Apache License 2.0
697 stars 17 forks source link

now.json seems to be deprecated #6

Closed olrtg closed 2 years ago

olrtg commented 2 years ago

After the ZEIT rebrand to Vercel seems like the now.json file now should be named vercel.json. (see https://github.com/codesandbox/codesandbox-client/issues/5052).

I have also found the schema (hosted by Vercel): https://vercel.com/changelog/schema-autocomplete-and-validation-for-vercel-json.

I have tried to compare the two files but i couldn't tell if there are differences.

The docs for the vercel.json file: https://vercel.com/docs/cli#project-configuration

I'm willing to make a PR but i don't know if i should add vercel.json to the fileMatch, create a new schema and/or delete the older schema.

Any recommendations?

b0o commented 2 years ago

Hi! This project doesn't control the schema catalog, it just converts the catalog into a Neovim-friendly format. Please raise an issue upstream for issues related to adding/removing/changing schemas.

That being said, vercel.json is already supported: https://github.com/b0o/SchemaStore.nvim/blob/002444f8c9c69eaf1f755ef1bd91c0860ec56cb9/lua/schemastore/catalog.lua#L905-L910

Are you having trouble getting the Vercel schema working?

olrtg commented 2 years ago

Hi! thanks for the quick reply. My bad then 😅 sorry about that.

b0o commented 2 years ago

No worries! Everything is working for you then? Happy to help if not.

amin1419 commented 2 years ago

https://github.com/b0o/SchemaStore.nvim/issues/6#issue-1134653530