b0o / incline.nvim

🎈 Floating statuslines for Neovim, winbar alternative
MIT License
759 stars 14 forks source link

[Bug] Setting z index throws an error #15

Closed akinsho closed 2 years ago

akinsho commented 2 years ago

Hi,

Sorry for the influx of feedback πŸ˜…. I noticed today whilst trying to get incline to stop overlaying telescope by dropping the z index that setting the z index causes an error to be thrown. It looks like the options in the window table are passed to the set window options wrapper function and since zindex is not a valid window key in normal circumstances it throws an error

Error executing vim.schedule lua callback: ...site/pack/packer/start/incline.nvim/lua/incline/util.lua:128: Error executing lua: ...site/pack/packer/start/incline.nvim/lua/incline/u
til.lua:136: Vim(setlocal):E518: Unknown option: zindex=49                                                                                                                           
stack traceback:                                                                                                                                                                     
        [C]: in function 'cmd'                                                                                                                                                       
        ...site/pack/packer/start/incline.nvim/lua/incline/util.lua:136: in function <...site/pack/packer/start/incline.nvim/lua/incline/util.lua:128>                               
        [C]: in function 'nvim_win_call'                                                                                                                                             
        ...site/pack/packer/start/incline.nvim/lua/incline/util.lua:128: in function 'win_set_local_options'                                                                         
        ...e/pack/packer/start/incline.nvim/lua/incline/winline.lua:141: in function 'refresh'                                                                                       
        ...e/pack/packer/start/incline.nvim/lua/incline/winline.lua:150: in function 'win'                                                                                           
        ...e/pack/packer/start/incline.nvim/lua/incline/winline.lua:199: in function 'render'                                                                                        
        ...e/pack/packer/start/incline.nvim/lua/incline/tabpage.lua:70: in function 'update'                                                                                         
        ...e/pack/packer/start/incline.nvim/lua/incline/manager.lua:59: in function 'fn'                                                                                             
        .../pack/packer/start/incline.nvim/lua/incline/debounce.lua:36: in function 'immediate'                                                                                      
        .../pack/packer/start/incline.nvim/lua/incline/debounce.lua:19: in function ''                                                                                               
        vim/_editor.lua: in function ''                                                                                                                                              
        vim/_editor.lua: in function <vim/_editor.lua:0>                                                                                                                             
stack traceback:                                                                                                                                                                     
        [C]: in function 'nvim_win_call'                                                                                                                                             
        ...site/pack/packer/start/incline.nvim/lua/incline/util.lua:128: in function 'win_set_local_options'                                                                         
        ...e/pack/packer/start/incline.nvim/lua/incline/winline.lua:141: in function 'refresh'                                                                                       
        ...e/pack/packer/start/incline.nvim/lua/incline/winline.lua:150: in function 'win'                                                                                           
        ...e/pack/packer/start/incline.nvim/lua/incline/winline.lua:199: in function 'render'                                                                                        
        ...e/pack/packer/start/incline.nvim/lua/incline/tabpage.lua:70: in function 'update'                                                                                         
        ...e/pack/packer/start/incline.nvim/lua/incline/manager.lua:59: in function 'fn'                                                                                             
        .../pack/packer/start/incline.nvim/lua/incline/debounce.lua:36: in function 'immediate'                                                                                      
        .../pack/packer/start/incline.nvim/lua/incline/debounce.lua:19: in function ''                                                                                               
        vim/_editor.lua: in function ''                                                                                                                                              
        vim/_editor.lua: in function <vim/_editor.lua:0>                        
akinsho commented 2 years ago

Actually that's my bad, it was a lingering packer compile issue from when I initially placed it inside the option's table first πŸ€¦πŸΎβ€β™‚οΈ

b0o commented 2 years ago

Glad you resolved it. And please don’t apologize for giving feedback, keep it coming!