search

b0o / incline.nvim

🎈 Floating statuslines for Neovim, winbar alternative
MIT License
759 stars 14 forks source link

fix: overlap the separator line in bottom mode #59

Closed Lattay closed 4 months ago

Lattay commented 5 months ago

Hi,

I wanted what was requested in #27 and realized it was not a complicated fix. Here it is :).

When window.placement.vertical == "bottom", this fix put the label on top of the split separator line. Of course it behave like before the fix if laststatus is not 3 or if the windows is at the bottom of the screen. I made sure that works with any value of cmdheigh too (notably because I use cmdheight=0)

Looks pretty cool in my opinion :+1: screenshot

I think this is a reasonable enough behavior (and symmetric to the top case) that it doesn't need to be configurable, but I can add some sort of switch if you prefer.

b0o commented 4 months ago

Hi there, thank you for your contribution!

However, another PR (#44) also adds this functionality, and was just merged. Therefore, this PR should no longer be necessary. This should now be possible with the following config:

require("incline").setup {
  window = {
    margin = { horizontal = 0, vertical = 0 },
    placement = { horizontal = 'center', vertical = 'bottom' },
    overlap = {
      tabline = false,
      winbar = true,
      borders = true,
      statusline = true,
    },
  },
}

I appreciate your contribution, and I hope you have a wonderful day.