b13 / bolt

Easier integrations for TYPO3 sites
GNU General Public License v2.0
27 stars 13 forks source link

FEATURE: Allow for configurable site package prefix #44

Open sorenmalling opened 9 months ago

sorenmalling commented 9 months ago

The newly introduced extension configuration allows to change the site package prefix.

By default it's value is site_. Changing this, will only have effect for displayed items in the list of site configuration module.

Resolves: #43

bmack commented 9 months ago

Let's just remove this check alltogether

sorenmalling commented 9 months ago

Let's just remove this check alltogether

And change the field to a simple string? List all packages?

I like the idea of separating packages responsible for rendering, hence my proposal

sorenmalling commented 9 months ago

Alternative, mentions in the documentation how you add a extra entry to the site configuration by using SiteConfiguration overrides

bmack commented 9 months ago

I'm not in favor of adding configuration options :) TYPO3 already has tons of them. We could alternatively

sorenmalling commented 9 months ago
* add more "common" prefixes or suffixes by default

For reference, our uncommon prefix of packages in charge of rendering is ucph_layout_ 😄

How about this, read the

    "extra": {
        "typo3/cms": {

        }
    }
}

part and look for site-package: true ?

sorenmalling commented 9 months ago

It could require a extension of the Package MetaData class, to contain the "extra" part, for a clean access to that data.

sorenmalling commented 9 months ago

Our, use a

  "type": "typo3-cms-site"

and use the already available $packageType - boom 🚀

I can provide a PR with a working example