b13 / link2language

Allows to set links to a specific language of a page in FormEngine and the RTE link selector
GNU General Public License v2.0
17 stars 10 forks source link

Compatibility with TYPO3 v11 #7

Closed brotkrueml closed 3 years ago

brotkrueml commented 3 years ago

Using this extension is very helpful. As we are now upgrading our website to TYPO3 v11, it would be nice to have the extension compatible with it.

I digged a little bit into it. The setting of the template root path must be muved from the initialize() method to the render method(), as $this->view is not available at this place. However, also the Page.html template changed a lot.

I see two possibilities:

For a clean approach I would go for the second variant and will try to add a PR, if this is okay.

bmack commented 3 years ago

Hey @brotkrueml ,

we're very much in favor of supporting as many TYPO3 Core versions as possible at the same time, so I'm in favor of adding a new PHP class for v11 which has different styles and implementation.

bmack commented 3 years ago

Interested in checking the PR?

brotkrueml commented 3 years ago

Yup, will do.