b2cm / id_ideal_wallet

Wallet Application supporting DIDs, VCs and DIDComm
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Also accept JWT as request object #3

Closed F-Node-Karlsruhe closed 6 months ago

F-Node-Karlsruhe commented 7 months ago

https://github.com/b2cm/id_ideal_wallet/blob/ad1880d6214c1f587601556d14255b5b200d73f8/lib/functions/oidc_handler.dart#L292

It is hidden quite deep down in the spec, but the requestObject must be encoded in a signed JWT in the current state.

https://openid.net/specs/openid-4-verifiable-presentations-1_0.html#name-authorization-request second sentence follow two links of RFC

Maybe support both for now?

F-Node-Karlsruhe commented 7 months ago

see other implementations https://github.com/Sphereon-Opensource/SIOP-OID4VP/blob/develop/src/request-object/RequestObject.ts#L52

SaOtto commented 6 months ago

I've noticed aswell that the request object should be a JWT. Support for it will be part of the next release.

SaOtto commented 6 months ago

Fixed with release 2.4.15