Refactoring: DRY Styles

b2cm / id_ideal_wallet

Wallet Application supporting DIDs, VCs and DIDComm

BSD 3-Clause "New" or "Revised" License

4 stars 1 forks source link

Refactoring: DRY Styles #4

Open Echsecutor opened 1 month ago

Echsecutor commented 1 month ago

Files like https://github.com/european-epc-competence-center/id_ideal_wallet/blob/branding1/lib/basicUi/standard/id_card.dart have hard coded RGB colors and other syle information all over the place.

Extract these colors into constants
- In a suitable file, e.g. under lib/constants
Make sure that everywhere colors, styles etc. should be the same, they reference the same constant
- (start by find all over code base ;) )

Echsecutor commented 1 month ago

@SaOtto I will have some of our students work on issues like this one. -> Should we track all changes that we intend to contribute as issues in your github? If so, could you give me the right to assign people to issues?

SaOtto commented 1 month ago

Thank you @Echsecutor, your contribution and the ones of your students is highly welcome. Please track with issues and pull requests.