Closed keithbowes closed 7 years ago
a plugin seems like the only sane way to go
Agreed
I can only assume the reason trackbacks aren't implemented via a plugin is that they date back to before plugins were available
Correct. I'd like to remove them from the core but so many other priorities...
should just create a standalone plugin instead?
Yes please. We'll publish it on plugins.b2evolution.net but would not want to bundle it. Same thing for trackbacks if we get to the point where we pluginize it, we won't bundle it. Also btw, we'll de-bundle quite a few non-essential plugins around v7.0. Also btw, we might add an easy download + install feature for plugins that are on plugins.b2evolution.net.
Change T_comments.comment_type to enum('comment', 'trackback', 'mention', 'meta'). 'linkback' would be removed, as it's not used anywhere in the code.
We can add 'mention' if you need it. Why change 'pingback' to 'mention' instead of having both (there is no cost to the DB).
change the actual code so that detecting the comment type would reflect one of the four new types (i.e. change case 'pingback': to case 'mention':).
Unless I am mistaken, this is for display/translation purposes only, so it would make sense that plugins provide the strings and if no plugin provides a string, we'll just display 'comment' or 'feedback' (which is another wording issue we never really squared out)
Of course, change "pingback" to "mention" in the translatable strings. Most likely, this would create easy-to-change fuzzy translations in the PO files.
As said above, I'd like this to move to the plugin and the plugin's translations.
Remove all references to pingbacks. It seems that they either were never implemented or were removed along the way.
They were removed years ago when we discovered they were broken + security issue + nobody interested in fixing them. We thought we'd put them back as a plugin if someone ever wanted to volunteer that plugin ;)
Considering they were replaced by Webmention, there's probably no reason to ever implement them.
Ok.
If my Webmention plugin would be a standalone plugin, I suppose I'll just add the Webmention comments to the 'pingback' type
We can still add the "mention" or "webmention" type to the DB so it's cleaner.
Hm. I suppose this issue should be closed then. I'll get around to moving my plugin from a branch on my b2evolution fork to a separate repo.
Webmention recently became a standard, replacing the quasi-standard Pingback, which itself was designed to be a replacement for the spam magnet known as trackbacks (seemingly the only type of linkback currently supported in b2evolution). I'd like to write a plugin to implement it (a plugin seems like the only sane way to go; I can only assume the reason trackbacks aren't implemented via a plugin is that they date back to before plugins were available). Before I get started, though, there are a few questions I have.
First and foremost, if I were to write the plugin, would it be worth my time and effort, to create a branch and send a pull request on completion? Or is there just no chance that it would get into b2evolution and I should just create a standalone plugin instead?
If it can get merged into b2evolution (again, it's a plugin, so users would have to explicitly enable it), here's what I'd plan to change:
case 'pingback':
tocase 'mention':
).What I'd like to do:
The one comment in inc/items/_item.class.php that makes me suspect that there was the infrastructure for pingback support but it was never implemented is:
If my Webmention plugin would be a standalone plugin, I suppose I'll just add the Webmention comments to the 'pingback' type, as there's already detection for that type in a
switch...case
statement in the skins (though, it wouldn't be completely accurate).