Remove test-prepare - Githubissues

b310-digital / mindwendel

Create a challenge. Ready? Brainstorm. mindwendel helps you to easily brainstorm and upvote ideas and thoughts within your team.

https://www.mindwendel.com

GNU Affero General Public License v3.0

72 stars 12 forks source link

Closed PragTob closed 2 days ago

PragTob commented 4 days ago

test-prepare seems to be unneeded and potentially harmful imo:

the tests run fine without it, as mix test runs pending migrations
reset also runs setup which runs the seeds which shouldn't be in the test DB env unless we want to use them as fixtures but then it'd probably better to separate dev seeds from test fixtures

So, I have it all running locally without ever running it :+1:

JannikStreek commented 3 days ago

conflict ⚔️

PragTob commented 2 days ago

Updated!