b3dgs / lionheart-remake

Java remake of Lionheart amiga game

https://lionheart.b3dgs.com

GNU General Public License v3.0

78 stars 7 forks source link

Liana cut may crash on Android #311

Closed ruthan closed 1 year ago

ruthan commented 2 years ago

TODO

[x] Improve liana cut performance to reduce computation overhead

Original comment

Expected Behavior

Be fluent.

Actual Behavior

Getting slower and slower to freeze.

Steps to Reproduce the Problem

Go to first place when you cut trough wall and cut through..

Specifications

Xperia 10 II

Lionheart Remake Version: 1.2.0
JDK: who knows..
OS: Android 11

DjThunder commented 2 years ago

You mean when cutting liana ? I can't reproduce the slowdown. Do you know the approximate playing duration before slowing down ? Can you tell me exactly your last location before bug ?

Thx !

ruthan commented 2 years ago

Its long time, just green walls which could be destroyed, if remember correctly..

If was start of game, i guess that is engine problem on low end devices.

DjThunder commented 2 years ago

Ah maybe. I will try to optimize at best then.

DjThunder commented 1 year ago

I found multiple reason, I i'm fixing them all to make game run smoother on old device. I tested on an old Samsung A5 (2017) with Android 6, it was almost impossible to approach liana area. Now it is as on computer, as fast (60fps). So it should work for you I hope !

I still need in depth testing, as I rewritten a lot of things, especially on collision computation side (tiles & objects).