b3nn0 / hassio-addon-ism7mqtt

HomeAssistant Addon for running ism7mqtt to fetch data from Wolf heaters
Apache License 2.0
29 stars 3 forks source link

Are there any plans for multiple Heatpumps? #32

Closed Hafenmeister31 closed 1 year ago

Hafenmeister31 commented 1 year ago

Hallo,

Great Addon, just installed it and i enjoy it a lot, exactly what i was looking for. Unfortunately, i have to integrate two heatpumps in one Home Assistant installation. Are there any plans to offer something like this in the future ?

Greetings Michael

b3nn0 commented 1 year ago

Would require to run ism7mqtt multiple times with different parameters. If someone creates a pull request that does that, I am happy to merge it.

zivillian commented 1 year ago

@Hafenmeister31 do you mean you have two separate ism7 modules, or two heatpumps connected to a single ism7 module? If there is only a single ism7 module, I may have to adjust the code of ism7mqtt - therefore you should open an issue at ism7mqtt

Hafenmeister31 commented 1 year ago

@zivillian I have two separate ism7 modules, one for each heat pump. Unfortunately i can only add one ism7 module to Home Assistant with this Addon. I already looked at the code and tried to make some sense of it with chatgpt in order to make a pull request, but i have no clue tbh. This would be just embarrassing 😂 🙈

b3nn0 commented 1 year ago

Probably would just have to modify the run.sh file then to manage multiple instances. HA's addon configuration isn't really able to dynamically add multiple configs.. so would either need a hard-coded amount, or probably better as an advanced configuration by editing the yaml directly...

b3nn0 commented 1 year ago

Just published addon version v0.0.14-1 This allows maniging multiple ism7mqtt instances. Additional instances can be configured in the text field on the bottom like this:

- device_name: "WolfHeizung2"
  ism7_ip: 192.168.x.x
  ism7_password: xxxx
  interval: 60

It's more or less untested, as I don't have multiple devices, but it seems to try to start the instances correctly

b3nn0 commented 1 year ago

Oops, had a bug in there that would accidentally use the same parameters.json for both instances. Fixed it in v0.0.14-2.

Hafenmeister31 commented 1 year ago

Wow, that was fast, thank you a lot. Unfortunately, my second ism7 is not here yet, so i can't test it. According to my installer it should arrive next week, i'll give you feedback as soon as possible.

Hafenmeister31 commented 1 year ago

Hey, i just wanted to give you some feedback. My second ISM7 came yesterday. I installed it and it works like a charm. Thank you !

b3nn0 commented 1 year ago

Nice