search

b3rs3rk / gpustat-unraid

An UnRAID plugin for displaying GPU status
https://forums.unraid.net/topic/89453-plugin-gpu-statistics/?tab=comments#comment-830112
MIT License
50 stars 14 forks source link

SUPPORTED_APPS #29

Closed corgan2222 closed 3 years ago

corgan2222 commented 3 years ago

Added support for two more apps:

grafik

b3rs3rk commented 3 years ago

@corgan2222 - I don't want this to sound rude, but did you read the Contributing guide before you got started?

image

If possible, please resubmit the PR to dev.

EDIT: https://docs.github.com/en/github/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request

EDIT 2: I didn't realize I could change the target, but it is done. Now you only need to address the other comments and it's good to go.

EDIT 3: Nevermind, it's going to have merge conflicts because of commits that exist in master that don't exist in Dev due to package builds and metadata updates. You need to reset your repo, and checkout the dev branch on your fork and then reapply the changes you've made. Sucks, I know.

corgan2222 commented 3 years ago

Sorry, every time I forget to create a new branch. The PR was only by accident, as I was looking through the code. I will redo the PR.

b3rs3rk commented 3 years ago

Thanks for opening a new one, and thanks for the contribution. I will review the new PR and hopefully merge soonest.