As discussed in Issue #99, here is my list of suggested changes to the source strings, along with some notes.
Lines 35 and 59:
I used "on your device" instead of "in your device", but I don't think it's a mistake per se, just a less commonly used expression(236M vs. 79M hits for both strings in Google). "In your device" implies virtual space, while "on device" highlights the fact it's just disk space. Which one should be used depends on the meaning the application focuses on.
In line 35, the deletion of which aims to preserve string length while adding "device" which I think sounds better. We might have actual androids in a few years and this could get confusing ;)
Line 43 is another candidate for "in" to "on" replacement, but I'd appreciate more opinions on this first.
Line 71 is the only one starting from a lowercase that is not the continuation of a string. Should it stay lowercase?
Lines 123-135 have seen a few changes to get capitalization under control, and I took the freedom of using negative adjectives instead of multiple "not"s
Lines 167-179 have had their dots removed. It's entirely for discussion whether they should be restored.
I'm not sure what line 211 does, so I don't know what it should really say. I think it deserves a clarification. Currently proposed string rewrite is based on my assumption on how it works
Capitalization in line 223 confuses me, but I think that's the string used in the right click in file managers and thus should have send from a lowercase letter
Please squash the commits before merging, my git knowledge is insufficient to do it myself :/
As discussed in Issue #99, here is my list of suggested changes to the source strings, along with some notes.
Lines 35 and 59: I used "on your device" instead of "in your device", but I don't think it's a mistake per se, just a less commonly used expression(236M vs. 79M hits for both strings in Google). "In your device" implies virtual space, while "on device" highlights the fact it's just disk space. Which one should be used depends on the meaning the application focuses on. In line 35, the deletion of which aims to preserve string length while adding "device" which I think sounds better. We might have actual androids in a few years and this could get confusing ;)
Line 43 is another candidate for "in" to "on" replacement, but I'd appreciate more opinions on this first.
Line 71 is the only one starting from a lowercase that is not the continuation of a string. Should it stay lowercase?
Lines 123-135 have seen a few changes to get capitalization under control, and I took the freedom of using negative adjectives instead of multiple "not"s
Lines 167-179 have had their dots removed. It's entirely for discussion whether they should be restored.
I'm not sure what line 211 does, so I don't know what it should really say. I think it deserves a clarification. Currently proposed string rewrite is based on my assumption on how it works
Capitalization in line 223 confuses me, but I think that's the string used in the right click in file managers and thus should have send from a lowercase letter
Please squash the commits before merging, my git knowledge is insufficient to do it myself :/