Use symbolic icons instead of current ones

[Marukesu]

Use smartphone-connected-symbolic and smartphone-disconnected-symbolic to keep only one version of the icons for light and dark desktops avoiding some design problems like these

[varlesh]

It's impossible, because pantheon not colorize 3-d party apps on tray. Create icon for your self, on Ubuntu all worked fine!

[varlesh]

This icons use for Gnome and Cinnamon:

• computer-symbolic
• laptop-symbolic
• smartphone-symbolic
• tablet-symbolic

This icons used for Ubuntu and eOS:

• laptop-connected
• laptop-disconnected
• laptop-trusted
• smartphone-connected
• smartphone-disconnected
• smartphone-trusted
• tablet-connected
• tablet-disconnected
• tablet-trusted

[Marukesu]

in Loki (0.4), eOS use symbolic icons.

[varlesh]

Also for Cinnamon and gnome use 16px icons size. But for Pantheon use 24px... you have big symbolic icon because use 16px on 24px tray. @Bajoja I'm not understand why not use NOT symbolic icons on Pantheon? @MrSadness When you change icon theme to ubuntu-mono-dark icon changed on tray? Use this icons?

[varlesh]

in Loki (0.4), eOS use symbolic icons.

But you see this not worked for 3-d party apps, because libbappindicator not have this option

[varlesh]

@Bajoja How this worked? If icon smartphone-connected not available use smartphone-symbolic or another method for Gnome, Unity, Pantheon and etc...?

[Marukesu]

@varlesh yes, ubuntu-mono works. but, the rest uses hicolor icons. now i take the elemntary phone icon and rename her to smartphone-connected and work.

[varlesh]

You can try this variant:

sudo cp /usr/share/icons/ubuntu-mono-dark/status/24/smartphone* /usr/share/icons/elementary/status/24/

[varlesh]

we not create elementary icons for kdeconnect because we must add depend elementary-icon-theme - it's not needed for Gnome, Cinnamon, Ubuntu and other DE

[b4j4]

@varlesh if it not available it uses the default theme icons, for the system.

[varlesh]

@Bajoja Ok, fine. @MrSadness you can copy this icons (24px) on elementary icon theme folder from ubuntu-mono-dark or create new icons for tray:

laptop-connected
laptop-disconnected
laptop-trusted
smartphone-connected
smartphone-disconnected
smartphone-trusted
tablet-connected
tablet-disconnected
tablet-trusted

[b4j4]

@MrSadness For now this is the best option, until we found a solution. @varlesh i think is good idea create icons for elementary, because a lot of people use it, and we don't need to add a depends of ..., just copy the icons to icons folder, and they occupy a little space that nobody will care.

[varlesh]

Ok, i'm create version for eOS, but colorize option not possible, because it's specific DE tool and not worked for 3-d party apps.

[b4j4]

Ok, thanks.

[varlesh]

done

[b4j4]

@MrSadnes Check if the new icons work, open this issue for any problems.

[Marukesu]

Ok, the icons are great! But only on dark wallpapers, on light wallpapers the icon is white while the rest is black.

But I fixed this problem :)

It is necessary to add + "-symbolic" to device.icon_name in DeviceIndicator.vala and rename the icons according (smartphone- status -symbolic) in both elementary and ubuntu-mono

[varlesh]

Now you icons blurred and bigger, because you use 16px-symbolic icons on 24px tray! It's not universal variant and not worked for non Vala apps - Qt, Electron and etc... because elementary icon theme not supported 3-d party apps: https://github.com/elementary/icons#third-party-brand-preservation

@Bajoja I'm not recommend add this fix to master branch because Gnome, Cinnamon and other DE use 16px symbolic icons by default, but Patheon use 24px. Icons will be blurred or very tiny.

[varlesh]

Icons for panel... Gnome (by default): SYMBOLIC ICONS - 16px 3-D PARTY APPS 16px, but have extension for change size tray icons to 22px or 24px and etc

Unity (by default): SYMBOLIC ICONS not used for panel 3-D PARTY APPS 22px only

Pantheon (by default): SYMBOLIC ICONS 24px for Vala/Native apps 3-D PARTY APPS 24px icons

[Marukesu]

@varlesh this icon is a place holder i take it from elementary symbolic icons for devices (not status)

[varlesh]

@MrSadnes you not understand me... Steeven say if icon smartphone-connected not available on icon theme use smartphone-symbolic.

BUT you see your icon blurred and bigger, because have another size. You icon have 16px size, but for Pantheon use only 24px for tray! We can't resize smartphone-symbolic from 16px to 24px for elementary only because icon will be blurred and very tiny on Gnome and Cinnamon! Also devices symbloic icons available an Gnome and Pantheon but not fully - not have icon laptop-symbolic for example and again problem with different sizes.

[b4j4]

I did not know that this in elementary was a mess, really now that I've been reading to third party applications does not work properly.

@MrSadnes i can't add '+ "-symbolic"' to the code for now because the icons that we use will not work.

@varlesh you recommend to undo the commit?

[varlesh]

@varlesh you recommend to undo the commit?

No, icon worked but not applied color modification. Pnatheon change symbolic icons on if use light wallpaper - it's specific DE option. Now i understand if icon use -symbolic suffix - pantheon apply another color for icon. But symbolic icons now installed to hicolor theme, but elementary icon theme not have option inherits for use hicolor icon theme or gnome and etc... Now we can add suffix -symbolic ubuntu-mono-dark and elementary icons and change sources for right work. Or modify sources for elementary only, but i don't know how this will be worked...

[varlesh]

@Bajoja smartphone-connected, smartphone-trusted and other icon NAMES used from kdeconnect? It's hardcoded icon names or not?

[Marukesu]

@varlesh According to the gnome website

Symbolic icons are usually low color or monochrome and intended to match the foreground font color

and hicolor,gnome,adwata symbolic icons works too.

[varlesh]

Now we have 3 variants icons for indicator-kdeconnect - all icons worked and looked fine, but on Pnatheon not apply color modification if you change wallpaper to light tone, because elementary icons not have suffix -symbolic

[varlesh]

@MrSadnes On indicator-kdeconnect used different icon names for appindicator and gnome! For appindicator: laptop-connected laptop-disconnected laptop-trusted smartphone-connected smartphone-disconnected smartphone-trusted tablet-connected tablet-disconnected tablet-trusted

For Gnome: computer-symbolic laptop-symbolic smartphone-symbolic tablet-symbolic

[varlesh]

I'm confused :laughing: @Bajoja Please tell how this worked? I see for ubuntu-mono available 9 icons, but symbolic have 4 icons, Why?

[varlesh]

trusted and disconnected not used for Gnome or how? Or maybe use colors for GTK/Shell theme?

[b4j4]

@varlesh, this things of icon are making me confused too.

But what happens is this, symbolic icons are monochromatic icons that just appear on the indicator to represent the device user are using, smartphone, computer, laptop or tablet, this why 4 icons only.
I modify indicator-kdeconnect to work with the 9 icons, that allows the icons change case they are trusted or untrusted, because is more simple distinguish your devices (trusted) from those that are not (untrusted).

In my school a lot of devices have kdeconnect, so imagine when i connect to the WIFI the number of devices that appear on my indicator, the only way to know what indicator is mine is have the trusted ones (normal icons) and the untrusted(red icons).

[varlesh]

@Bajoja symbolic icons use colors from Gnome Shell theme for disconnected and trusted status?

[b4j4]

@varlesh do not use.

I use that you create for ubuntu mono :) kkkk.

[varlesh]

@Bajoja We can modify sources for Pantheon? Need add -symbolic suffix for all icons ubuntu-mono and elementary.

[varlesh]

i mean this icon names:

laptop-connected-symbolic
laptop-disconnected-symbolic
laptop-trusted-symbolic
smartphone-connected-symbolic
smartphone-disconnected-symbolic
smartphone-trusted-symbolic
tablet-connected-symbolic
tablet-disconnected-symbolic
tablet-trusted-symbolic

[b4j4]

@varlesh it not use symbolic icons, it use the scalable ones.

[b4j4]

if we modify the sources i don't know if it will work for systems not use symbolic icons like mine.

[varlesh]

Yes and Pantheon use another size for symbolic icons on panel... OMG it's crazy - very many DE's and standards :)

[varlesh]

@MrSadnes i think better disable this option for dark icons on tray because it's very strange method... Other tray apps, for example telegram, skype, vlc and etc will be look ugly too.

[b4j4]

@varlesh yah, it's a lot of standards, so it's not easy to help everyone.

Some people have to do like me, replace them manually.

[Marukesu]

Ok then I will keep the code on my pc since it is working in the elementary (the other themes carry the symbolic icons but not the indicator) and try to find a way to use both symbolic and scalable

[b4j4]

@MrSadnes i will. ;)

[Marukesu]

Ok, I finally figure out how the icons work ... and I did not do anything XD

1. yes, when + "-symbolic" is added to the indicator, scalable icons continue to work.

2. I created a few more simple icons for the Adwaita/gnome theme (they are symbolic because it is the default theme) to make the indicator more complete being these inherits for most themes

images: Elementary (Symbolics)

Ubuntu-mono (Scalables)

Adwaita/Gnome(Symbolics)

This Only works with -symbolic suffix becasue of the default fallabacks are: { smartphone-connected-symbolic smartphone-connected smartphone }

[b4j4]

Ok, i will check this, can you zip and upload this icons? I will need them for test.

[Marukesu]

here

[Marukesu]

I made this PR for the support of symbolic icons that allowed the integration of the indicator to themes that use it