b4j4 / indicator-kdeconnect

AppIndicator for KDE Connect
GNU Lesser General Public License v2.1
372 stars 38 forks source link

Translation issues #99

Closed pshem closed 7 years ago

pshem commented 7 years ago

I did the Polish translation for the project a few weeks back and I'm now reviewing it to see if I can make any improvements. I'd like to point out a few inconsistencies in how the strings are used, and inquire about possible polishing of the source strings. Here are some of the issues that were noticeable:

  1. Capitalization:
  1. missing mention of F-Droid as a source for KDE Connect download(String 6). F-Droid is one of the three official sources you can download the android part of KDE Connect from, along with Google Play Store and the source code. As KDE Connect Indicator is also open source, I believe it should promote the only public open-source Android repository, and have added a mention of it to the Polish translation. @comradekingu, who did the Norwegian translation, seems to agree, as his translation also mentions F-Droid.

  2. Missing plurals and "a"/"an". For example string 4 currently says:

If you have Firewall running, please open port 1714-1764 for TCP and UDP

The correct form should be:

If you have a Firewall running, please open ports 1714-1764 for TCP and UDP

If I were to improve the original and not just fix it, I'd make it read:

If you have a firewall running, please open TCP and UDP ports 1714-1764

  1. This is not a mistake, just something that bugs me: punctuation, especially '.' at the end of strings. I'm not an English native, and I'd really appreciate if one chimed in on the topic. Since my initial translation, hosted weblate has started enforcing formatting similarity, ie. translations of source strings that end with a '.' have to end with a '.' too. In a lot of the strings, the '.' at the end feels forced and artificial(Strings: 7, 11, 38, 39)

  2. I would also appreciate guidance on whether "Indicator" in the name of the application should be translated. So far, I've left it untranslated. This is mainly relevant for string 12

I'm not sure what to suggest at this point, as many translations have been made and it would be a waste to have them disappear only because of formatting changes, which other translators may have already adjusted in their translations. If you agree, I could make an English(GB) translation showing how I think most of the source strings should look like.

I would appreciate if other translators chimed in, so I'm mentioning everyone I identified from the .po merge commits: @vdragon, @slsimic, @png2378, @vistaus, @welaq, @ShellAddicted, @BathoryPeter, @muzena, @iota-dev, @fitojb, @thomazio, @p-bo, @victorenator

b4j4 commented 7 years ago

@pshem, i agree with you, so you make changes on the main pot file, and submit your changes as pull request, then we can the source strings should look like.

pshem commented 7 years ago

Ok, I'll try to have it done by next weekend