Logic question || bug || feature - merge master into PR

b4mboo / prophet

An easy way to loop through open pull requests and run code on the merged branch.

MIT License

9 stars 8 forks source link

Logic question || bug || feature - merge master into PR #4

Closed kalabiyau closed 10 years ago

kalabiyau commented 10 years ago

Based on https://github.com/b4mboo/prophet/blob/master/lib/prophet/prophet.rb#L210

we do not merge master into pull request. That means we always just testing pr itself but not the potential merge with master. Was it anyhow intentionally?

kalabiyau commented 10 years ago

Closed as seems problem is outside of prophet

b4mboo commented 10 years ago

You already closed this, but just FYI: There is no need to merge master into the PR. GitHub basically already does that to check whether it is mergeable. So the little note on the bottom of the PR page that says "this can be merged automatically" takes care of that. I linked a YouTube video in the README.md that explains this with a little more detail, if you are interested.