b8ne / react-native-pusher-push-notifications

Manage pusher interest subscriptions and notification events in Javascript.
MIT License
96 stars 85 forks source link

Unable to run on android 12 & playstore is rejecting bundle #100

Open arjsp opened 1 year ago

arjsp commented 1 year ago

My project uses react-native-pusher-push-notifications for push notification. But the app is failing to launch on android 12 devices. The issue showing when trying to launch on emulator is

android:exported needs to be explicitly specified for element <activity#com.pusher.pushnotifications.reporting.OpenNotificationActivity>

Also when uploading the bundle on play store console it shows

You uploaded an APK or Android App Bundle which has an activity, activity alias, service or broadcast receiver with intent filter, but without 'android:exported' property set. This file can't be installed on Android 12 or higher. See: developer.android.com/about/versions/12/behavior-changes-12#exported

The issue is resolved once I uploaded a release bundle after removing react-native-pusher-push-notifications. So clearly the issue is with this package. How this can be solved IOS is working fine

leonardo409188 commented 1 year ago

You need add android:exported="true or false" in all service and activity about pusher in Android manifest. <activity android:name="com.pusher.pushnotifications.reporting.OpenNotificationActivity" android:exported="true">

arjsp commented 1 year ago

Thanks @leonardo409188 for the replay. But the build I took after adding this still getting rejected. Is there anyway to know what are the other services or activities by pusher so that I can add exported: true for all of those

Arkan4ik commented 1 year ago

@arjsp have you found the problem?have the same

bAngerman commented 1 year ago

I ended up downloading the 2.5.3 version of this repository (as it seems to not be available on yarn/npm) and use patch-package to maintain these changes to the package (copy zip contents into node_modules/react-native-pusher-push-notifications/, run patch-package react-native-pusher-push-notifications in project root. This is dependant on you having setup patch-package on the project).

After taking these steps I can compile for Android 12 and submit to the play store.